Skip to content

Commit aaba096

Browse files
committed
improve handling of validation errors
1 parent 4a17ea7 commit aaba096

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

nodescraper/cli/inputargtypes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def process_file_arg(self, file_path: str) -> TModelType:
104104
return self.model(**data)
105105
except ValidationError as e:
106106
raise argparse.ArgumentTypeError(
107-
f"Validation errors when processing {file_path}: {e.errors()}"
107+
f"Validation errors when processing {file_path}: {e.errors(include_url=False)}"
108108
) from e
109109

110110

nodescraper/interfaces/dataanalyzertask.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,12 @@ def wrapper(
7676
if not analyze_arg_model:
7777
raise ValueError("No model defined for analysis args")
7878
args = analyze_arg_model(**args) # type: ignore
79-
8079
func(analyzer, data, args)
8180
except ValidationError as exception:
8281
analyzer._log_event(
8382
category=EventCategory.RUNTIME,
8483
description="Validation error during analysis",
85-
data=get_exception_traceback(exception),
84+
data={"errors": exception.errors(include_url=False)},
8685
priority=EventPriority.CRITICAL,
8786
console_log=True,
8887
)

nodescraper/interfaces/datacollectortask.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
from nodescraper.interfaces.task import SystemCompatibilityError, Task
4242
from nodescraper.models import DataModel, SystemInfo, TaskResult
4343
from nodescraper.typeutils import TypeUtils
44-
from nodescraper.utils import get_exception_details, get_exception_traceback
44+
from nodescraper.utils import get_exception_traceback
4545

4646
from .connectionmanager import TConnection
4747
from .taskresulthook import TaskResultHook
@@ -76,7 +76,7 @@ def wrapper(
7676
collector._log_event(
7777
category=EventCategory.RUNTIME,
7878
description="Pydantic validation error",
79-
data=get_exception_details(exception),
79+
data={"errors": exception.errors(include_url=False)},
8080
priority=EventPriority.CRITICAL,
8181
console_log=True,
8282
)

0 commit comments

Comments
 (0)