removed err throw for invalid plugin

Author: alexandraBara

nodescraper/cli/cli.py

@@ -338,7 +338,18 @@ def process_args(
         else:
             cur_plugin = None
             for arg in plugin_args:
-                if arg in plugin_names:
+                # Handle comma-separated plugin names (but not arguments)
+                if not arg.startswith("-") and "," in arg:
+                    # Split comma-separated plugin names
+                    for potential_plugin in arg.split(","):
+                        potential_plugin = potential_plugin.strip()
+                        if potential_plugin in plugin_names:
+                            plugin_arg_map[potential_plugin] = []
+                            cur_plugin = potential_plugin
+                        elif potential_plugin:
+                            # Track invalid plugin names to log event later
+                            invalid_plugins.append(potential_plugin)
+                elif arg in plugin_names:
                     plugin_arg_map[arg] = []
                     cur_plugin = arg
                 elif cur_plugin:

nodescraper/pluginexecutor.py

@@ -33,7 +33,6 @@
 from pydantic import BaseModel
 
 from nodescraper.constants import DEFAULT_LOGGER
-from nodescraper.enums import ExecutionStatus
 from nodescraper.interfaces import ConnectionManager, DataPlugin, PluginInterface
 from nodescraper.models import PluginConfig, SystemInfo
 from nodescraper.models.pluginresult import PluginResult
@@ -120,13 +119,6 @@ def run_queue(self) -> list[PluginResult]:
                 plugin_name, plugin_args = plugin_queue.popleft()
                 if plugin_name not in self.plugin_registry.plugins:
                     self.logger.error("Unable to find registered plugin for name %s", plugin_name)
-                    plugin_results.append(
-                        PluginResult(
-                            status=ExecutionStatus.ERROR,
-                            source=plugin_name,
-                            message=f"Plugin '{plugin_name}' not found in registry",
-                        )
-                    )
                     continue
 
                 plugin_class = self.plugin_registry.plugins[plugin_name]
@@ -148,13 +140,6 @@ def run_queue(self) -> list[PluginResult]:
                             "Unable to find registered connection manager class for %s that is required by",
                             connection_manager_class.__name__,
                         )
-                        plugin_results.append(
-                            PluginResult(
-                                status=ExecutionStatus.ERROR,
-                                source=plugin_name,
-                                message=f"Connection manager '{connection_manager_class.__name__}' not found in registry",
-                            )
-                        )
                         continue
 
                     if connection_manager_class not in self.connection_library:
@@ -201,13 +186,6 @@ def run_queue(self) -> list[PluginResult]:
                             plugin_name,
                             str(ve),
                         )
-                        plugin_results.append(
-                            PluginResult(
-                                status=ExecutionStatus.ERROR,
-                                source=plugin_name,
-                                message=f"Invalid global_args for plugin: {str(ve)}",
-                            )
-                        )
                         continue
 
                     self.logger.info("-" * 50)

test/functional/test_run_plugins.py

@@ -100,3 +100,16 @@ def test_run_plugin_with_invalid_name(run_cli_command):
     assert "running default config" in output.lower() or "NodeStatus" in output
     # Verify it didn't crash
     assert "Data written to csv file" in output
+
+
+def test_run_comma_separated_plugins_with_invalid(run_cli_command):
+    """Test that comma-separated plugins run valid ones and ignore invalid ones."""
+    result = run_cli_command(["run-plugins", "AmdSmiPlugin,SomePlugin"], check=False)
+
+    output = result.stdout + result.stderr
+    # Check that warning was logged for invalid plugin
+    assert "Invalid plugin name(s) ignored: SomePlugin" in output
+    # Check that AmdSmiPlugin actually ran
+    assert "Running plugin AmdSmiPlugin" in output
+    # Verify it didn't crash
+    assert "Data written to csv file" in output