addressed reviews

Author: alexandraBara

nodescraper/models/collectorargs.py

@@ -28,17 +28,3 @@
 
 class CollectorArgs(BaseModel):
     model_config = {"extra": "forbid", "exclude_none": True}
-
-    @classmethod
-    def build_from_model(cls, datamodel):
-        """Build collector args instance from data model object
-
-        Args:
-            datamodel (TDataModel): data model to use for creating collector args
-
-        Raises:
-            NotImplementedError: Not implemented error
-        """
-        raise NotImplementedError(
-            "Setting collector args from datamodel is not implemented for class: %s", cls.__name__
-        )

test/unit/framework/test_collectorargs.py

@@ -1,5 +1,3 @@
-import pytest
-
 from nodescraper.models import CollectorArgs
 
 
@@ -18,8 +16,3 @@ def test_build_from_model(dummy_data_model):
     assert args.args_foo == dummy.foo
     dump = args.model_dump(mode="json", exclude_none=True)
     assert dump == {"args_foo": 1}
-
-
-def test_base_build_from_model_not_implemented():
-    with pytest.raises(NotImplementedError):
-        CollectorArgs.build_from_model("anything")