Merge branch 'development' into alex_diff_logs

Author: alexandraBara

nodescraper/cli/cli.py

@@ -329,9 +329,10 @@ def main(arg_input: Optional[list[str]] = None):
         system_info = get_system_info(parsed_args)
 
         if parsed_args.log_path and parsed_args.subcmd not in ["gen-plugin-config", "describe"]:
+            sname = system_info.name.lower().replace("-", "_").replace(".", "_")
             log_path = os.path.join(
                 parsed_args.log_path,
-                f"scraper_logs_{system_info.name}_{datetime.datetime.now().strftime('%Y_%m_%d-%I_%M_%S_%p')}",
+                f"scraper_logs_{sname}_{datetime.datetime.now().strftime('%Y_%m_%d-%I_%M_%S_%p')}",
             )
             os.makedirs(log_path)
         else:

nodescraper/plugins/inband/process/collector_args.py

@@ -28,3 +28,5 @@
 
 class ProcessCollectorArgs(BaseModel):
     top_n_process: int = 10
+
+    model_config = {"extra": "forbid"}

test/unit/framework/test_analyzerargs.py

@@ -13,7 +13,6 @@ def build_from_model(cls, datamodel):
 
 def test_build_from_model(dummy_data_model):
     dummy = dummy_data_model(foo=1)
-    # args = args.build_from_model(dummy)
     args = MyArgs.build_from_model(dummy)
     assert isinstance(args, MyArgs)
     assert args.args_foo == dummy.foo