added unit tests

Author: jaspals

test/functional/fixtures/package_plugin_config.json

@@ -2,6 +2,9 @@
   "global_args": {},
   "plugins": {
     "PackagePlugin": {
+      "collection_args": {
+        "rocm_regex": "rocm|hip|hsa|amdgpu"
+      },
       "analysis_args": {
         "exp_package_ver": {
           "gcc": "11.4.0"

test/unit/plugin/test_package_collector.py

@@ -222,3 +222,146 @@ def test_bad_splits_ubuntu(collector, conn_mock, command_results):
     ]
     res, _ = collector.collect_data()
     assert res.status == ExecutionStatus.OK
+
+
+def test_rocm_package_filtering_default_regex(collector, conn_mock, command_results):
+    """Test ROCm package filtering with default regex pattern."""
+    # Mock Ubuntu system with ROCm packages
+    ubuntu_packages = """rocm-core 5.7.0
+                    hip-runtime-amd 5.7.0
+                    hsa-rocr 1.9.0
+                    amdgpu-dkms 6.3.6
+                    gcc 11.4.0
+                    python3 3.10.12"""
+
+    conn_mock.run_command.side_effect = [
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=command_results["ubuntu_rel"],
+            stderr="",
+        ),
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=ubuntu_packages,
+            stderr="",
+        ),
+    ]
+
+    res, data = collector.collect_data()
+    assert res.status == ExecutionStatus.OK
+    # Check that ROCm packages are found
+    assert "rocm" in res.message.lower()
+    assert data is not None
+    # Verify all packages are collected
+    assert len(data.version_info) == 6
+
+
+def test_rocm_package_filtering_custom_regex(collector, conn_mock, command_results):
+    """Test ROCm package filtering with custom regex pattern."""
+    from nodescraper.plugins.inband.package.analyzer_args import PackageAnalyzerArgs
+
+    # Mock Ubuntu system with ROCm packages
+    ubuntu_packages = """rocm-core 5.7.0
+                    hip-runtime-amd 5.7.0
+                    hsa-rocr 1.9.0
+                    amdgpu-dkms 6.3.6
+                    gcc 11.4.0
+                    python3 3.10.12"""
+
+    conn_mock.run_command.side_effect = [
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=command_results["ubuntu_rel"],
+            stderr="",
+        ),
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=ubuntu_packages,
+            stderr="",
+        ),
+    ]
+
+    # Use custom regex that only matches 'rocm' and 'hip'
+    args = PackageAnalyzerArgs(rocm_regex="rocm|hip")
+    res, data = collector.collect_data(args)
+    assert res.status == ExecutionStatus.OK
+    # Check that ROCm packages are found
+    assert "found 2 rocm-related packages" in res.message.lower()
+    assert data is not None
+
+
+def test_rocm_package_filtering_no_matches(collector, conn_mock, command_results):
+    """Test ROCm package filtering when no ROCm packages are installed."""
+    from nodescraper.plugins.inband.package.analyzer_args import PackageAnalyzerArgs
+
+    # Mock Ubuntu system without ROCm packages
+    ubuntu_packages = """gcc 11.4.0
+                    python3 3.10.12
+                    vim 8.2.3995"""
+
+    conn_mock.run_command.side_effect = [
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=command_results["ubuntu_rel"],
+            stderr="",
+        ),
+        CommandArtifact(
+            command="",
+            exit_code=0,
+            stdout=ubuntu_packages,
+            stderr="",
+        ),
+    ]
+
+    args = PackageAnalyzerArgs(rocm_regex="rocm|hip|hsa")
+    res, data = collector.collect_data(args)
+    assert res.status == ExecutionStatus.OK
+    # No ROCm packages found, so message should not mention them
+    assert "rocm" not in res.message.lower() or res.message == ""
+    assert data is not None
+    assert len(data.version_info) == 3
+
+
+def test_filter_rocm_packages_method(collector):
+    """Test _filter_rocm_packages method directly."""
+    packages = {
+        "rocm-core": "5.7.0",
+        "hip-runtime-amd": "5.7.0",
+        "hsa-rocr": "1.9.0",
+        "amdgpu-dkms": "6.3.6",
+        "gcc": "11.4.0",
+        "python3": "3.10.12",
+    }
+
+    # Test with default-like pattern
+    rocm_pattern = "rocm|hip|hsa|amdgpu"
+    filtered = collector._filter_rocm_packages(packages, rocm_pattern)
+
+    assert len(filtered) == 4
+    assert "rocm-core" in filtered
+    assert "hip-runtime-amd" in filtered
+    assert "hsa-rocr" in filtered
+    assert "amdgpu-dkms" in filtered
+    assert "gcc" not in filtered
+    assert "python3" not in filtered
+
+
+def test_filter_rocm_packages_case_insensitive(collector):
+    """Test that ROCm package filtering is case-insensitive."""
+    packages = {
+        "ROCM-Core": "5.7.0",
+        "HIP-Runtime-AMD": "5.7.0",
+        "gcc": "11.4.0",
+    }
+
+    rocm_pattern = "rocm|hip"
+    filtered = collector._filter_rocm_packages(packages, rocm_pattern)
+
+    assert len(filtered) == 2
+    assert "ROCM-Core" in filtered
+    assert "HIP-Runtime-AMD" in filtered