Skip to content

Commit f5e3d8c

Browse files
committed
addressed reviews
1 parent c58d3b1 commit f5e3d8c

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

nodescraper/plugins/inband/kernel_module/kernel_module_analyzer.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,8 @@ def analyze_data(
202202
self.result.status = ExecutionStatus.ERROR
203203
return self.result
204204
else:
205-
self.result.message = "Kernel modules and regex_filter failed"
206-
self.result.status = ExecutionStatus.ERROR
205+
self.result.message = (
206+
"No values provided in analysis args for: kernel_modules and regex_match"
207+
)
208+
self.result.status = ExecutionStatus.NOT_RAN
207209
return self.result

test/unit/plugin/test_kernel_module_analyzer.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,3 +109,12 @@ def test_analyze_data_name_only_success(data_model, analyzer):
109109
result = analyzer.analyze_data(data_model, args)
110110
assert result.status == ExecutionStatus.OK
111111
assert result.message == "task completed successfully"
112+
113+
114+
def test_no_analyzer_args(data_model, analyzer):
115+
args = KernelModuleAnalyzerArgs(kernel_modules={}, regex_filter=[])
116+
result = analyzer.analyze_data(data_model, args)
117+
assert result.status == ExecutionStatus.NOT_RAN
118+
assert (
119+
result.message == "No values provided in analysis args for: kernel_modules and regex_match"
120+
)

0 commit comments

Comments
 (0)