addressed reviews

Author: alexandraBara

nodescraper/plugins/inband/sysctl/sysctl_analyzer.py

@@ -43,9 +43,6 @@ def analyze_data(
         self, data: SysctlDataModel, args: Optional[SysctlAnalyzerArgs] = None
     ) -> TaskResult:
         """Analyze the Sysctl data against expected Sysctl values."""
-        self.result = self.result
-        self.result.status = ExecutionStatus.OK
-        self.result.message = "All expected sysctl parameters match."
         mismatches = {}
 
         if not args:
@@ -79,5 +76,7 @@ def analyze_data(
                 priority=EventPriority.INFO,
                 console_log=True,
             )
+            self.result.status = ExecutionStatus.OK
+            self.result.message = "All expected sysctl parameters match."
 
         return self.result

nodescraper/plugins/inband/sysctl/sysctl_collector.py

@@ -79,7 +79,7 @@ def collect_data(
         if values:
             sysctl_data = SysctlDataModel(**values)
             self._log_event(
-                category="SYSCTL_READ",
+                category="OS",
                 description="Sysctl settings read",
                 data=sysctl_data.model_dump(),
                 priority=EventPriority.INFO,