feat(fetchye-one-app): only execute streamFetchye action on server (#113)

* feat(fetchye-one-app): only execute streamFetchye action on server

* refactor(fetchye-one-app): prevent dispatching stream action on client

Author: dominic-farquharson

packages/fetchye-one-app/__tests__/streaming/streamFetchye.spec.js

@@ -27,6 +27,21 @@ const streamActionSpy = jest.spyOn(actions, 'stream');
 const mockDispatch = jest.fn();
 
 describe('streamFetchye', () => {
+  const originalWindow = global.window;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    Object.defineProperty(global, 'window', {
+      value: undefined,
+      configurable: true,
+      writable: true,
+    });
+  });
+
+  afterEach(() => {
+    global.window = originalWindow;
+  });
+
   it('should return a one-app-thunk that dispatches an action resolving to the passed in thunk', async () => {
     expect.assertions(2);
 
@@ -63,4 +78,21 @@ describe('streamFetchye', () => {
     );
     expect(fetchyeThunk).toHaveBeenCalledWith(...fetchyeParams.slice(1));
   });
+
+  it('should not dispatch the stream action on the client', async () => {
+    expect.assertions(1);
+
+    global.window = originalWindow;
+
+    const fetchyeThunk = jest.fn();
+    fetchyeThunk.mockResolvedValue(Symbol('fetchRequest'));
+
+    const fetchyeParams = [fetchyeThunk, Symbol('fetchyeArgs - key'), Symbol('fetchyeArgs - options'), Symbol('fetchyeArgs - fetcher')];
+    const streamFetchyeThunk = streamFetchye(...fetchyeParams);
+    const thunkParams = [mockDispatch, Symbol('getState'), Symbol('fetchClient')];
+    await streamFetchyeThunk(
+      fetchyeThunk, thunkParams[0], thunkParams[1], { fetchClient: thunkParams[2] }
+    );
+    expect(streamActionSpy).not.toHaveBeenCalled();
+  });
 });

packages/fetchye-one-app/src/streaming/streamFetchye.js

@@ -23,15 +23,17 @@ export const streamFetchye = (thunk, key, opts = {}, fetcher = undefined) => asy
   const { hash: computedKey } = computeKey(key, opts);
   const promise = dispatch(thunk(key, opts, fetcher));
 
-  dispatch(
-    stream([
-      {
-        key: computedKey,
-        domain: STREAM_DOMAIN,
-        promise,
-      },
-    ])
-  );
+  if (!global.window) {
+    dispatch(
+      stream([
+        {
+          key: computedKey,
+          domain: STREAM_DOMAIN,
+          promise,
+        },
+      ])
+    );
+  }
 
   return promise;
 };