fix(makeServerFetchye): mask errors from server side fetching (#49)

* fix(makeServerFetchye): mask errors from server side fetching

* fix(copyright): add copyright to new file

* test(ssrFetcher): Make assersion more specific

correct copyright year

Author: code-forger

packages/fetchye-core/__tests__/ssrFetcher.spec.js

@@ -0,0 +1,38 @@
+/*
+ * Copyright 2021 American Express Travel Related Services Company, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+import { ssrFetcher } from '../src/ssrFetcher';
+import { defaultFetcher } from '../src/defaultFetcher';
+
+jest.mock('../src/defaultFetcher', () => ({
+  defaultFetcher: jest.fn(() => ({
+    payload: 'payloadMock',
+    error: 'errorMock',
+  })),
+}));
+
+describe('ssrFetcher', () => {
+  it('forward all params to the default fetcher, and return the payload from the default fetcher with error: null', async () => {
+    const parameters = ['paramMock1', 'paramMock2', 'paramMock3'];
+    const response = await ssrFetcher(...parameters);
+    expect(response).toEqual({
+      payload: 'payloadMock',
+      error: null,
+    });
+
+    expect(defaultFetcher.mock.calls[0]).toEqual(parameters);
+  });
+});

packages/fetchye-core/src/index.js

@@ -19,4 +19,5 @@ export * from './actions';
 export { defaultEqualityChecker } from './defaultEqualityChecker';
 export { FetchyeContext } from './FetchyeContext';
 export { defaultFetcher } from './defaultFetcher';
+export { ssrFetcher } from './ssrFetcher';
 export { default as useSubscription } from './useSubscription';

packages/fetchye-core/src/ssrFetcher.js

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2021 American Express Travel Related Services Company, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+import { defaultFetcher } from './defaultFetcher';
+
+export const ssrFetcher = async (...params) => {
+  const { payload } = await defaultFetcher(...params);
+  return {
+    payload,
+    error: null,
+  };
+};
+
+export default ssrFetcher;

packages/fetchye/__tests__/makeServerFetchye.spec.js

@@ -113,7 +113,7 @@ describe('makeServerFetchye', () => {
       }
     `);
   });
-  it('should return error in error state', async () => {
+  it('should return null in the error state', async () => {
     const fetchClient = jest.fn(async () => {
       throw new Error('fake error');
     });
@@ -133,7 +133,7 @@ describe('makeServerFetchye', () => {
     expect(fetchyeRes).toMatchInlineSnapshot(`
       Object {
         "data": null,
-        "error": "Error: fake error",
+        "error": null,
       }
     `);
   });

packages/fetchye/src/makeServerFetchye.js

@@ -15,7 +15,7 @@
  */
 
 // eslint-disable-next-line import/no-unresolved
-import { defaultFetcher } from 'fetchye-core';
+import { ssrFetcher } from 'fetchye-core';
 import SimpleCache from './SimpleCache';
 import { runAsync } from './runAsync';
 import { computeKey } from './computeKey';
@@ -29,7 +29,7 @@ const makeServerFetchye = ({
 }) => async (
   key,
   { mapOptionsToKey = (options) => options, ...options } = { },
-  fetcher = defaultFetcher
+  fetcher = ssrFetcher
 ) => {
   const { cacheSelector } = cache;
   const computedKey = computeKey(key, defaultMapOptionsToKey(mapOptionsToKey(options)));