Skip to content

Commit fd44eb6

Browse files
committed
chore(sync): added code to sync changes with pr#98
1 parent 6e80500 commit fd44eb6

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

packages/fetchye/__tests__/queryHelpers.spec.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,19 @@ describe('isLoading', () => {
3737
})).toEqual(true);
3838
});
3939

40+
it('should return true if numOfRenders === 1 and options.forceInitialFetch === true', () => {
41+
expect(isLoading({
42+
loading: false,
43+
numOfRenders: 1,
44+
data: {},
45+
options: {
46+
defer: false,
47+
forceInitialFetch: true,
48+
},
49+
error: undefined,
50+
})).toEqual(true);
51+
});
52+
4053
it('should return false if there are errors present', () => {
4154
expect(isLoading({
4255
loading: false, options: { defer: false }, error: { },

packages/fetchye/src/queryHelpers.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
export const isLoading = ({
18-
loading, data, options, error,
18+
loading, data, numOfRenders, options, error,
1919
}) => {
2020
// if defer is true
2121
if (options.defer) {
@@ -30,7 +30,7 @@ export const isLoading = ({
3030
}
3131

3232
// Here to mimic what happens in the useEffect
33-
if (!data && !error) {
33+
if ((!data && !error) || (numOfRenders === 1 && options.forceInitialFetch === true)) {
3434
return true;
3535
}
3636

packages/fetchye/src/useFetchye.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ const useFetchye = (
6363
data: selectorState.current.data || options.initialData?.data,
6464
options,
6565
error: selectorState.current.error,
66+
numOfRenders: numOfRenders.current,
6667
}),
6768
error: passInitialData(
6869
selectorState.current.error,

0 commit comments

Comments
 (0)