amilajack
diff --git a/‎.babelrc‎
Lines changed: 0 additions & 54 deletions b/‎.babelrc‎
Lines changed: 0 additions & 54 deletions
diff --git a/‎.env.example‎
Lines changed: 2 additions & 5 deletions b/‎.env.example‎
Lines changed: 2 additions & 5 deletions
diff --git a/‎.eslintrc‎
Lines changed: 0 additions & 25 deletions b/‎.eslintrc‎
Lines changed: 0 additions & 25 deletions
diff --git a/‎.gitignore‎
Lines changed: 0 additions & 2 deletions b/‎.gitignore‎
Lines changed: 0 additions & 2 deletions
diff --git a/‎.travis.yml‎
Lines changed: 2 additions & 4 deletions b/‎.travis.yml‎
Lines changed: 2 additions & 4 deletions
diff --git a/‎README.md‎
Lines changed: 10 additions & 7 deletions b/‎README.md‎
Lines changed: 10 additions & 7 deletions
diff --git a/‎app/api/Player.js‎
Lines changed: 5 additions & 2 deletions b/‎app/api/Player.js‎
Lines changed: 5 additions & 2 deletions
diff --git a/‎app/api/Subtitle.js‎
Lines changed: 8 additions & 0 deletions b/‎app/api/Subtitle.js‎
Lines changed: 8 additions & 0 deletions
diff --git a/‎app/api/Torrent.js‎
Lines changed: 9 additions & 2 deletions b/‎app/api/Torrent.js‎
Lines changed: 9 additions & 2 deletions
diff --git a/‎app/api/players/ChromecastPlayerProvider.js‎
Lines changed: 29 additions & 6 deletions b/‎app/api/players/ChromecastPlayerProvider.js‎
Lines changed: 29 additions & 6 deletions
@@ -72,12 +72,9 @@ CONFIG_MAX_CONNECTIONS=20
 
 # English subtitles support
 #
-# This flag allows subtitles in torrents to be played along with the movie. Be
-# careful, since this is a very early stage experiment! Currently this only
-# allows English subtitles. Support for subtitles of multiple languages is
-# planned for a future release.
+# This flag allows subtitles in torrents to be played along with the movie
 
-FLAG_SUBTITLES=false
+FLAG_SUBTITLES=true
 
 
 
 
@@ -39,8 +39,6 @@ flow-typed/npm/*
 release
 app/main.prod.js
 app/main.prod.js.map
-app/bundle.js
-app/bundle.js.map
 app/style.css
 app/style.css.map
 dist
 
@@ -7,21 +7,19 @@ matrix:
       language: node_js
       node_js:
         - node
-        - 9
       env:
         - ELECTRON_CACHE=$HOME/.cache/electron
         - ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder
     - os: linux
       language: node_js
       node_js:
         - node
-        - 9
       addons:
         apt:
           sources:
             - ubuntu-toolchain-r-test
           packages:
-            - g++-4.8
+            - g++-8
             - icnsutils
             - graphicsmagick
             - xz-utils
@@ -49,7 +47,7 @@ cache:
     - "$HOME/docker"
 
 install:
-  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then export CXX="g++-4.8"; fi
+  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then export CXX="g++-8"; fi
   - yarn
   - |
     if [ "$TRAVIS_OS_NAME" == "linux" ]; then
 
@@ -24,19 +24,22 @@
   </a>
 </div>
 
+<div>
+  <img src="https://raw.github.com/amilajack/popcorn-time-desktop-design/master/Desktop.jpg" width="500px"/>
+</div>
+
 <br />
 
-## Features:
 
-**Modern**: This client was started from scratch and was designed to be performant and customizable
+## Features:
 
-**Performance**: Significantly faster than other clients. Everything from scrolling perf to playing movies is buttery smooth
+* ✨ **Modern**: This client was started from scratch and was designed to be performant and customizable
 
-**Faster Torrents**: New API optimized for fast torrents by querying the from multiple endpoints
+* ⏩ **Performance**: Significantly faster than other clients. Everything from scrolling perf to playing movies is buttery smooth
 
-**Modern Stack**: Electron, React, Redux, Webpack, ES8, Flow, and others
+* 💨**Faster Torrents**: New API optimized for fast torrents by querying the from multiple endpoints
 
-**Cross Platform**: Works on Mac, Windows, and Linux
+* ✅**Cross Platform**: Works on Mac, Windows, and Linux
 
 ## Getting started:
 
@@ -60,7 +63,7 @@ cd popcorn-time-desktop
 # 💡 For casting support, you will need to satisfy mdns's requirements:
 # For windows install bonjour: https://support.apple.com/downloads/bonjour_for_windows
 # For linux, make sure you have these dependencies installed with apt-get:
-# https://github.com/amilajack/popcorn-time-desktop/blob/v1.2.0/.travis.yml#L24-L35
+# https://github.com/amilajack/popcorn-time-desktop/blob/v1.3.0/.travis.yml#L24-L35
 
 # Install dependencies
 # Have a cup of coffee ☕️ this might take a while
 
@@ -7,6 +7,8 @@ import vlcCommand from 'vlc-command';
 import ChromecastPlayerProvider from './players/ChromecastPlayerProvider';
 import type { metadataType } from './players/PlayerProviderInterface';
 
+export type subtitleType = { kind: string, src: string, srclang: string };
+
 const { powerSaveBlocker } = remote;
 
 export default class Player {
@@ -62,11 +64,12 @@ export default class Player {
   async initCast(
     provider: ChromecastPlayerProvider,
     streamingUrl: string,
-    metadata: metadataType
+    metadata: metadataType,
+    subtitles: Array<subtitleType>
   ) {
     this.powerSaveBlockerId = powerSaveBlocker.start('prevent-app-suspension');
     const addr = streamingUrl.replace('localhost', network());
-    return provider.play(addr, metadata);
+    return provider.play(addr, metadata, subtitles);
   }
 
   initYouTube() {
 
@@ -31,6 +31,14 @@ export default class SubtitleServer {
 
     // Start the static file server for the subtitle files
     const server = express();
+    // Enable CORS
+    // https://github.com/thibauts/node-castv2-client/wiki/How-to-use-subtitles-with-the-DefaultMediaReceiver-app#subtitles
+    server.use((req, res, next) => {
+      if (req.headers.origin) {
+        res.headers['Access-Control-Allow-Origin'] = req.headers.origin;
+      }
+      next();
+    });
     server.use(express.static(this.basePath));
     this.server = server.listen(this.port);
 
 
@@ -65,7 +65,13 @@ export default class Torrent {
     magnetURI: string,
     metadata: metadataType,
     supportedFormats: Array<string>,
-    cb
+    cb: (
+      servingUrl: string,
+      file: { name: string },
+      files: string,
+      torrent: string,
+      subtitle: { name: string } | boolean
+    ) => void
   ) {
     if (this.inProgress) {
       console.log('Torrent already in progress');
@@ -159,7 +165,8 @@ export default class Torrent {
             file,
             files,
             torrent,
-            selectSubtitleFile(files, activeMode, metadata)
+            false
+            // selectSubtitleFile(files, activeMode, metadata)
           );
 
           this.clearIntervals();
 
@@ -1,10 +1,12 @@
 // @flow
 import { Client, DefaultMediaReceiver } from 'castv2-client';
 import mdns from 'mdns';
+import network from 'network-address';
 import type {
   PlayerProviderInterface,
   deviceType,
-  metadataType
+  metadataType,
+  subtitleType
 } from './PlayerProviderInterface';
 
 type castv2DeviceType = {
@@ -81,13 +83,28 @@ class ChromecastPlayerProvider implements PlayerProviderInterface {
     return selectedDevice;
   }
 
-  play(contentUrl: string, metadata: metadataType) {
+  play(
+    contentUrl: string,
+    metadata: metadataType,
+    subtitles: Array<subtitleType>
+  ) {
     const client = new Client();
 
     if (!this.selectDevice) {
       throw new Error('No device selected');
     }
 
+    const networkAddress = network();
+    const tracks = subtitles.map((subtitle, index) => ({
+      trackId: index, // This is an unique ID, used to reference the track
+      type: 'TEXT', // Default Media Receiver currently only supports TEXT
+      trackContentId: subtitle.src.replace('localhost', networkAddress), // the URL of the VTT (enabled CORS and the correct ContentType are required)
+      trackContentType: 'text/vtt', // Currently only VTT is supported
+      name: subtitle.srclang, // a Name for humans
+      language: subtitle.srclang, // the language
+      subtype: 'SUBTITLES' // should be SUBTITLES
+    }));
+
     return new Promise((resolve, reject) => {
       client.connect(
         this.selectedDevice.address,
@@ -101,6 +118,8 @@ class ChromecastPlayerProvider implements PlayerProviderInterface {
               contentType: 'video/mp4',
               streamType: 'BUFFERED', // or LIVE
 
+              tracks,
+
               // Title and cover displayed while buffering
               metadata: {
                 type: 0,
@@ -117,10 +136,14 @@ class ChromecastPlayerProvider implements PlayerProviderInterface {
               }
             };
 
-            player.load(media, { autoplay: true }, _err => {
-              if (_err) reject(_err);
-              resolve();
-            });
+            player.load(
+              media,
+              { autoplay: true, activeTrackIds: tracks.map(e => e.trackId) },
+              _err => {
+                if (_err) reject(_err);
+                resolve();
+              }
+            );
           });
         }
       );