CustomAppPredictor: Handle component name changes#601
Open
nyancrimew wants to merge 1 commit intoamirzaidi:o-mr1from
Open
CustomAppPredictor: Handle component name changes#601nyancrimew wants to merge 1 commit intoamirzaidi:o-mr1from
nyancrimew wants to merge 1 commit intoamirzaidi:o-mr1from
Conversation
Actually check if the saved activity still exists and find a new launch intent for the packagename if it doesn't. If no launch intent is found the app was uninstalled so we can remove it completely. Signed-off-by: Till Kottmann <me@deletescape.ch>
amirzaidi
reviewed
Oct 18, 2018
Owner
amirzaidi
left a comment
amirzaidi
left a comment
There was a problem hiding this comment.
It's a good idea but the entire code will be rewritten in Pie. I'll keep the MR open until the bug has been fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually check if the saved activity still exists and find a new launch intent for the packagename if it doesn't. If no launch intent is found the app was uninstalled so we can remove it completely.