ignore notified.notifications.argoproj.io annotations (argoproj-labs#71)

MalibuKoKo · web-flow · commit 4bd78eadfbbb · 2021-04-15T19:45:58.000+02:00
Co-authored-by: Nicolas COLLET &lt;n.collet@of2m.fr&gt;
diff --git a/argocd/structure_metadata.go b/argocd/structure_metadata.go
@@ -59,5 +59,8 @@ func metadataIsInternalKey(annotationKey string) bool {
 	if err == nil && strings.HasSuffix(u.Hostname(), "kubernetes.io") {
 		return true
 	}
+	if err == nil && annotationKey == "notified.notifications.argoproj.io" {
+		return true
+	}
 	return false
 }
diff --git a/argocd/structure_metadata_test.go b/argocd/structure_metadata_test.go
@@ -16,6 +16,7 @@ func TestMetadataIsInternalKey(t *testing.T) {
 		{"any.hostname.com/with/path", false},
 		{"any.kubernetes.io", true},
 		{"kubernetes.io", true},
+		{"notified.notifications.argoproj.io", true},
 	}
 	for i, tc := range testCases {
 		t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -59,5 +59,8 @@ func metadataIsInternalKey(annotationKey string) bool {`
`59`	`59`	`if err == nil && strings.HasSuffix(u.Hostname(), "kubernetes.io") {`
`60`	`60`	`return true`
`61`	`61`	`}`
	`62`	`+ if err == nil && annotationKey == "notified.notifications.argoproj.io" {`
	`63`	`+ return true`
	`64`	`+ }`
`62`	`65`	`return false`
`63`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ func TestMetadataIsInternalKey(t *testing.T) {`
`16`	`16`	`{"any.hostname.com/with/path", false},`
`17`	`17`	`{"any.kubernetes.io", true},`
`18`	`18`	`{"kubernetes.io", true},`
	`19`	`+ {"notified.notifications.argoproj.io", true},`
`19`	`20`	`}`
`20`	`21`	`for i, tc := range testCases {`
`21`	`22`	`t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {`