Skip to content

Commit 59a0604

Browse files
authored
Merge pull request #239 from adangel/build-improvements
Build improvements
2 parents 304ba29 + 12ed746 commit 59a0604

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

.github/workflows/build.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ jobs:
3232
outputs:
3333
version: ${{ steps.properties.outputs.version }}
3434
changelog: ${{ steps.properties.outputs.changelog }}
35-
pluginVerifierHomeDir: ${{ steps.properties.outputs.pluginVerifierHomeDir }}
3635
steps:
3736

3837
# Check out the current repository
@@ -64,7 +63,6 @@ jobs:
6463
CHANGELOG="$(./gradlew getChangelog --unreleased --no-header --console=plain -q)"
6564
6665
echo "version=$VERSION" >> $GITHUB_OUTPUT
67-
echo "pluginVerifierHomeDir=~/.pluginVerifier" >> $GITHUB_OUTPUT
6866
6967
echo "changelog<<EOF" >> $GITHUB_OUTPUT
7068
echo "$CHANGELOG" >> $GITHUB_OUTPUT
@@ -154,17 +152,19 @@ jobs:
154152
# Setup Gradle
155153
- name: Setup Gradle
156154
uses: gradle/actions/setup-gradle@v4
157-
158-
# Cache Plugin Verifier IDEs
159-
- name: Setup Plugin Verifier IDEs Cache
160-
uses: actions/cache@v4
161155
with:
162-
path: ${{ needs.build.outputs.pluginVerifierHomeDir }}/ides
163-
key: plugin-verifier-${{ hashFiles('build/listProductsReleases.txt') }}
156+
# We don't store the cache of the verify job, as it takes too much space.
157+
# It contains each IntelliJ IDEA version we test against. These versions
158+
# are stored in ~/.gradle/caches/*/transforms/*/*/ideaIC* and each takes about 3GB.
159+
# Use "du -hs ~/.gradle/caches/*/transforms/*/*/ideaIC*" to verify.
160+
# This would be part of the cache "gradle-transforms-v1-...".
161+
# Also, the cache "gradle-dependencies-v1-..." is much bigger for verify job.
162+
# In total, the new caches are bigger than 10GB, which are available on GitHub by default.
163+
cache-read-only: true
164164

165165
# Run Verify Plugin task and IntelliJ Plugin Verifier tool
166166
- name: Run Plugin Verification tasks
167-
run: ./gradlew verifyPlugin -Dplugin.verifier.home.dir=${{ needs.build.outputs.pluginVerifierHomeDir }}
167+
run: ./gradlew verifyPlugin
168168

169169
# Collect Plugin Verifier Result
170170
- name: Collect Plugin Verifier Result

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ intellijPlatform {
106106

107107
pluginVerification {
108108
ides {
109+
// https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-pluginVerification-ides
110+
// recommended() automatically tests based on the current platformVersion
109111
recommended()
110112
}
111113
}

gradle.properties

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,11 @@ pluginSinceBuild = 233
1212
# no upper bound for the version range -> see https://github.com/amitdev/PMD-Intellij/issues/213
1313
pluginUntilBuild =
1414

15-
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
16-
# See https://jb.gg/intellij-platform-builds-list for available build versions.
17-
# Supporting five last major versions covers about 95% of the users
18-
# see https://intellij-support.jetbrains.com/hc/en-us/community/posts/18697727524754/comments/18765441074962
19-
# see https://plugins.jetbrains.com/docs/marketplace/product-versions-in-use-statistics.html
20-
pluginVerifierIdeVersions = IC-2023.3, IC-2024.1, IC-2024.2, IC-2024.3, IC-2025.1
21-
2215
platformType = IC
23-
platformVersion = 2024.1
16+
# https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html#multipleIDEVersions
17+
# When supporting multiple major versions, it is strongly recommended to build against
18+
# the _lowest_ supported version to guarantee backwards-compatibility.
19+
platformVersion = 2023.3
2420
#platformVersion = 251-EAP-SNAPSHOT
2521
org.jetbrains.intellij.platform.downloadSources=true
2622

0 commit comments

Comments
 (0)