Skip to content

Commit 62de0a4

Browse files
fix: correct neovim utils script path reference
Change incorrect reference from 'neovim_utils.sh' to 'utils/neovim.sh'. The wrong path was causing chmod failures during remote neovim installation. Updates provider code and corresponding tests.
1 parent 4c5e8e3 commit 62de0a4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lua/remote-nvim/providers/provider.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ function Provider:_setup_workspace_variables()
215215
self._remote_neovim_download_script_path =
216216
utils.path_join(self._remote_is_windows, self._remote_scripts_path, "neovim_download.sh")
217217
self._remote_neovim_utils_script_path =
218-
utils.path_join(self._remote_is_windows, self._remote_scripts_path, "neovim_utils.sh")
218+
utils.path_join(self._remote_is_windows, self._remote_scripts_path, "utils/neovim.sh")
219219
self._remote_workspace_id_path =
220220
utils.path_join(self._remote_is_windows, self._remote_workspaces_path, self._remote_workspace_id)
221221

tests/remote-nvim/providers/provider_spec.lua

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ describe("Provider", function()
171171
assert.equals(("%s/scripts"):format(remote_home), provider._remote_scripts_path)
172172
assert.equals(("%s/scripts/neovim_install.sh"):format(remote_home), provider._remote_neovim_install_script_path)
173173
assert.equals(("%s/scripts/neovim_download.sh"):format(remote_home), provider._remote_neovim_download_script_path)
174-
assert.equals(("%s/scripts/neovim_utils.sh"):format(remote_home), provider._remote_neovim_utils_script_path)
174+
assert.equals(("%s/scripts/utils/neovim.sh"):format(remote_home), provider._remote_neovim_utils_script_path)
175175
assert.equals(("%s/workspaces/%s"):format(remote_home, workspace_id), provider._remote_workspace_id_path)
176176

177177
-- XDG variables
@@ -636,7 +636,7 @@ describe("Provider", function()
636636
-- install neovim if needed
637637
assert.stub(run_command_stub).was.called_with(
638638
match.is_ref(provider),
639-
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/neovim_utils.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64",
639+
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/utils/neovim.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64",
640640
match.is_string()
641641
)
642642

@@ -695,7 +695,7 @@ describe("Provider", function()
695695

696696
assert.stub(run_command_stub).was.called_with(
697697
match.is_ref(provider),
698-
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/neovim_utils.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64 -o",
698+
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/utils/neovim.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64 -o",
699699
match.is_string()
700700
)
701701
end)
@@ -719,7 +719,7 @@ describe("Provider", function()
719719

720720
assert.stub(run_command_stub).was.called_with(
721721
match.is_ref(provider),
722-
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/neovim_utils.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64 -o",
722+
"chmod +x ~/.remote-nvim/scripts/neovim_download.sh && chmod +x ~/.remote-nvim/scripts/utils/neovim.sh && chmod +x ~/.remote-nvim/scripts/neovim_install.sh && bash ~/.remote-nvim/scripts/neovim_install.sh -v stable -d ~/.remote-nvim -m binary -a x86_64 -o",
723723
match.is_string()
724724
)
725725
end)

0 commit comments

Comments
 (0)