Skip to content

Commit 7fda0d4

Browse files
authored
add todo comment
Signed-off-by: ashiven <nevisha@pm.me>
1 parent 608b8f8 commit 7fda0d4

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

embark/workers/tasks.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -724,15 +724,12 @@ def _update_or_create_worker(config: Configuration, ip_address: str):
724724
)
725725
worker.save()
726726
worker.configurations.set([config])
727+
finally:
727728
try:
729+
# TODO: The first two function calls may cause issues when a config
730+
# is re-scanned after its first successful scan
728731
init_sudoers_file(config, worker)
729732
setup_ssh_key(config, worker)
730-
except BaseException:
731-
logger.error("Failed to setup SSH key or sudoers file for worker %s", worker.name)
732-
worker.delete()
733-
return
734-
finally:
735-
try:
736733
update_system_info(worker)
737734
update_dependencies_info(worker)
738735
except BaseException:

0 commit comments

Comments
 (0)