Use str_increment() to fix PHP 8.5 deprecation (#222)

nicolas-grekas · kelunik · web-flow · commit 321b45ae771d · 2025-08-27T23:55:40.000+02:00
Co-authored-by: Niklas Keller &lt;me@kelunik.com&gt;
diff --git a/composer-require-check.json b/composer-require-check.json
@@ -18,6 +18,7 @@
         "never",
         "object",
         "random_bytes",
+        "str_increment",
         "readKey",
         "flattenArgument",
         "formatFlattenedBacktrace",
diff --git a/psalm.xml b/psalm.xml
@@ -41,6 +41,12 @@
             </errorLevel>
         </UndefinedClass>
 
+        <UndefinedFunction>
+            <errorLevel type="suppress">
+                <referencedFunction name="str_increment"/>
+            </errorLevel>
+        </UndefinedFunction>
+
         <UnsupportedPropertyReferenceUsage>
             <errorLevel type="suppress">
                 <directory name="src"/>
diff --git a/src/Worker/Internal/TaskSubmission.php b/src/Worker/Internal/TaskSubmission.php
@@ -14,7 +14,9 @@ final class TaskSubmission extends JobPacket
     public function __construct(Task $task)
     {
         $this->task = $task;
-        parent::__construct(self::$nextId++);
+        $id = self::$nextId;
+        \PHP_VERSION_ID >= 80300 ? self::$nextId = \str_increment(self::$nextId) : ++self::$nextId;
+        parent::__construct($id);
     }
 
     public function getTask(): Task

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,9 @@ final class TaskSubmission extends JobPacket`
`14`	`14`	`public function __construct(Task $task)`
`15`	`15`	`{`
`16`	`16`	`$this->task = $task;`
`17`		`- parent::__construct(self::$nextId++);`
	`17`	`+ $id = self::$nextId;`
	`18`	`+ \PHP_VERSION_ID >= 80300 ? self::$nextId = \str_increment(self::$nextId) : ++self::$nextId;`
	`19`	`+ parent::__construct($id);`
`18`	`20`	`}`
`19`	`21`
`20`	`22`	`public function getTask(): Task`