Replace loop in setUp()

Author: trowski

src/AsyncTestCase.php

@@ -24,6 +24,16 @@ abstract class AsyncTestCase extends PHPUnitTestCase
     /** @var int Minimum runtime in milliseconds. */
     private $minimumRuntime = 0;
 
+    /** @var bool */
+    private $setUpInvoked = false;
+
+    protected function setUp()
+    {
+        $this->setUpInvoked = true;
+        Loop::set((new Loop\DriverFactory)->create());
+        \gc_collect_cycles(); // extensions using an event loop may otherwise leak the file descriptors to the loop
+    }
+
     /**
      * @codeCoverageIgnore Invoked before code coverage data is being collected.
      */
@@ -44,29 +54,32 @@ final public function runAsyncTest(...$args)
     {
         parent::setName($this->realTestName);
 
+        if (!$this->setUpInvoked) {
+            $this->fail(\sprintf(
+                '%s::setUp() overrides %s::setUp() without calling the parent method',
+                \str_replace("\0", '@', \get_class($this)), // replace NUL-byte in anonymous class name
+                self::class
+            ));
+        }
+
         $returnValue = null;
 
-        try {
-            $start = \microtime(true);
+        $start = \microtime(true);
 
-            Loop::run(function () use (&$returnValue, $args) {
-                try {
-                    $returnValue = yield call([$this, $this->realTestName], ...$args);
-                } finally {
-                    if (isset($this->timeoutId)) {
-                        Loop::cancel($this->timeoutId);
-                    }
+        Loop::run(function () use (&$returnValue, $args) {
+            try {
+                $returnValue = yield call([$this, $this->realTestName], ...$args);
+            } finally {
+                if (isset($this->timeoutId)) {
+                    Loop::cancel($this->timeoutId);
                 }
-            });
-
-            $actualRuntime = (int) (\round(\microtime(true) - $start, self::RUNTIME_PRECISION) * 1000);
-            if ($this->minimumRuntime > $actualRuntime) {
-                $msg = 'Expected test to take at least %dms but instead took %dms';
-                $this->fail(\sprintf($msg, $this->minimumRuntime, $actualRuntime));
             }
-        } finally {
-            Loop::set((new Loop\DriverFactory)->create());
-            \gc_collect_cycles(); // extensions using an event loop may otherwise leak the file descriptors to the loop
+        });
+
+        $actualRuntime = (int) (\round(\microtime(true) - $start, self::RUNTIME_PRECISION) * 1000);
+        if ($this->minimumRuntime > $actualRuntime) {
+            $msg = 'Expected test to take at least %dms but instead took %dms';
+            $this->fail(\sprintf($msg, $this->minimumRuntime, $actualRuntime));
         }
 
         return $returnValue;

test/InvalidAsyncTestCaseTest.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Amp\PHPUnit\Test;
+
+use Amp\PHPUnit\AsyncTestCase;
+use PHPUnit\Framework\AssertionFailedError;
+
+class InvalidAsyncTestCaseTest extends AsyncTestCase
+{
+    protected function setUp()
+    {
+        // No call to parent::setUp()
+
+        $this->expectException(AssertionFailedError::class);
+        $this->expectExceptionMessage('without calling the parent method');
+    }
+
+    /**
+     * @expectedException \Error
+     * @expectedExceptionMessage without calling the parent method
+     */
+    public function testMethod()
+    {
+        // Test will fail because setUp() did not call the parent method
+    }
+}