code review comments

aalavandhan · aalavandhan · commit 666833a8f4e2 · 2024-10-31T20:56:47.000-04:00
diff --git a/contracts/UFragmentsPolicy.sol b/contracts/UFragmentsPolicy.sol
@@ -385,11 +385,12 @@ contract UFragmentsPolicy is Ownable {
                     maxSupplyInHistory = epochSupply;
                 }
             }
-            int256 allowedSupplyMinimum = maxSupplyInHistory
+            int256 allowedMin = maxSupplyInHistory
                 .mul(ONE.sub(tolerableDeclinePercentage))
                 .div(ONE);
-            newSupply = (newSupply > allowedSupplyMinimum) ? newSupply : allowedSupplyMinimum;
-            require(newSupply <= currentSupply);
+            if (newSupply < allowedMin) {
+                newSupply = allowedMin;
+            }
         }
 
         return newSupply.sub(currentSupply);

Original file line number	Diff line number	Diff line change
`@@ -385,11 +385,12 @@ contract UFragmentsPolicy is Ownable {`
`385`	`385`	`maxSupplyInHistory = epochSupply;`
`386`	`386`	`}`
`387`	`387`	`}`
`388`		`- int256 allowedSupplyMinimum = maxSupplyInHistory`
	`388`	`+ int256 allowedMin = maxSupplyInHistory`
`389`	`389`	`.mul(ONE.sub(tolerableDeclinePercentage))`
`390`	`390`	`.div(ONE);`
`391`		`- newSupply = (newSupply > allowedSupplyMinimum) ? newSupply : allowedSupplyMinimum;`
`392`		`- require(newSupply <= currentSupply);`
	`391`	`+ if (newSupply < allowedMin) {`
	`392`	`+ newSupply = allowedMin;`
	`393`	`+ }`
`393`	`394`	`}`
`394`	`395`
`395`	`396`	`return newSupply.sub(currentSupply);`