feat: add user control for assignment event tracking

Author: vaibhav-jain-exp

Sources/Experiment/ExperimentClient.swift

@@ -513,8 +513,8 @@ internal class DefaultExperimentClient : NSObject, ExperimentClient {
             request.setValue(flagKeysB64EncodedUrl, forHTTPHeaderField: "X-Amp-Exp-Flag-Keys")
         }
 
-        // Add tracking option from current options or from stored setting
-        let trackingOptionValue = options?.trackingOption ?? trackingOptionStorageQueue.sync { trackingOption.get(key: "default") }
+        // Add tracking option from stored setting
+        let trackingOptionValue = trackingOptionStorageQueue.sync { trackingOption.get(key: "default") }
         if let trackingOptionValue = trackingOptionValue {
             request.setValue(trackingOptionValue, forHTTPHeaderField: "X-Amp-Exp-Track")
         }

Sources/Experiment/FetchOptions.swift

@@ -9,10 +9,8 @@ import Foundation
 
 @objc public class FetchOptions : NSObject {
     @objc public let flagKeys: [String]?
-    @objc public let trackingOption: String?
 
-    @objc public init(_ flagKeys: [String]? = nil, trackingOption: String? = nil) {
+    @objc public init(_ flagKeys: [String]? = nil) {
         self.flagKeys = flagKeys
-        self.trackingOption = trackingOption
     }
 }

Tests/ExperimentTests/ExperimentClientTests.swift

@@ -1255,8 +1255,8 @@ class ExperimentClientTests: XCTestCase {
         let client = DefaultExperimentClient(apiKey: "", config: config, storage: InMemoryStorage())
         XCTAssertEqual(900000, client.config.flagConfigPollingIntervalMillis)
     }
-
-        func testSetTrackAssignmentEvent() {
+    
+    func testSetTrackAssignmentEventSetsTrackingOptionAndFetchUsesCorrectOptions() {
         let client = DefaultExperimentClient(
             apiKey: API_KEY,
             config: ExperimentConfigBuilder()
@@ -1265,22 +1265,22 @@ class ExperimentClientTests: XCTestCase {
             storage: InMemoryStorage()
         )
 
-        // Test setting track assignment event to true
+        // Set track assignment event to true
         client.setTrackAssignmentEvent(true)
 
         // Verify the setting was stored
         let storedOption = client.trackingOption.get(key: "default")
         XCTAssertEqual(storedOption, "track")
 
-        // Test setting track assignment event to false
+        // Set track assignment event to false
         client.setTrackAssignmentEvent(false)
 
         // Verify the setting was updated
         let updatedOption = client.trackingOption.get(key: "default")
         XCTAssertEqual(updatedOption, "no-track")
     }
 
-    func testSetTrackAssignmentEventPersistence() {
+    func testSetTrackAssignmentEventPersistsSettingToStorage() {
         let storage = InMemoryStorage()
 
         // Create first client and set track assignment event
@@ -1307,7 +1307,7 @@ class ExperimentClientTests: XCTestCase {
         XCTAssertEqual(storedOption, "track")
     }
 
-    func testSetTrackAssignmentEventMultipleCalls() {
+    func testMultipleCallsToSetTrackAssignmentEventUsesLatestSetting() {
         let client = DefaultExperimentClient(
             apiKey: API_KEY,
             config: ExperimentConfigBuilder()
@@ -1325,7 +1325,7 @@ class ExperimentClientTests: XCTestCase {
         XCTAssertEqual(storedOption, "no-track")
     }
 
-    func testSetTrackAssignmentEventWithFetchOptions() {
+    func testSetTrackAssignmentEventPreservesOtherExistingOptions() {
         let client = DefaultExperimentClient(
             apiKey: API_KEY,
             config: ExperimentConfigBuilder()
@@ -1337,48 +1337,18 @@ class ExperimentClientTests: XCTestCase {
         // Set track assignment event to true
         client.setTrackAssignmentEvent(true)
 
-        // Create fetch options with flag keys
-        let fetchOptions = FetchOptions(["test-flag"], trackingOption: "no-track")
-        
-        // Verify that explicit tracking option in fetch options takes precedence
-        XCTAssertEqual(fetchOptions.trackingOption, "no-track")
-        XCTAssertEqual(fetchOptions.flagKeys, ["test-flag"])
-    }
-    
-    func testSetTrackAssignmentEventDefaultBehavior() {
-        let client = DefaultExperimentClient(
-            apiKey: API_KEY,
-            config: ExperimentConfigBuilder()
-                .debug(true)
-                .build(),
-            storage: InMemoryStorage()
-        )
-        
-        // Verify default behavior when setTrackAssignmentEvent is not called
+        // Verify the tracking option is set
         let storedOption = client.trackingOption.get(key: "default")
-        XCTAssertNil(storedOption)
-    }
-    
-    func testSetTrackAssignmentEventWithFetch() {
-        let client = DefaultExperimentClient(
-            apiKey: API_KEY,
-            config: ExperimentConfigBuilder()
-                .debug(true)
-                .build(),
-            storage: InMemoryStorage()
-        )
+        XCTAssertEqual(storedOption, "track")
 
-        // Set track assignment event to false
-        client.setTrackAssignmentEvent(false)
+        // Test that FetchOptions can still be created with flag keys
+        let fetchOptions = FetchOptions(["test-flag"])
+        XCTAssertEqual(fetchOptions.flagKeys, ["test-flag"])
 
-        let s = DispatchSemaphore(value: 0)
-        client.fetch(user: testUser) { (client, error) in
-            // The fetch should complete successfully
-            // The tracking option should be included in the request headers
-            XCTAssertNil(error)
-            s.signal()
-        }
-        s.wait()
+        // Verify that both the tracking option and flag keys can coexist
+        // (The tracking option is stored separately from FetchOptions)
+        XCTAssertNotNil(storedOption)
+        XCTAssertNotNil(fetchOptions.flagKeys)
     }
 }