Eliminate unnecessary double loop for XPath query since DOMNodeList is not live

Author: westonruter

includes/embeds/class-amp-facebook-embed.php

@@ -79,11 +79,13 @@ public function sanitize_raw_embeds( Document $dom ) {
 		 */
 		$fb_root = $dom->getElementById( 'fb-root' );
 		if ( $fb_root ) {
-			$scripts = [];
-			foreach ( $dom->xpath->query( '//script[ starts-with( @src, "https://connect.facebook.net" ) and contains( @src, "sdk.js" ) ]' ) as $script ) {
-				$scripts[] = $script;
-			}
-			foreach ( $scripts as $script ) {
+			/**
+			 * Script.
+			 *
+			 * @var DOMElement $script
+			 */
+			$script_query = $dom->xpath->query( '//script[ starts-with( @src, "https://connect.facebook.net" ) and contains( @src, "sdk.js" ) ]' );
+			foreach ( $script_query as $script ) {
 				$parent_node = $script->parentNode;
 				$parent_node->removeChild( $script );
 

tests/php/test-amp-facebook-embed.php

@@ -215,7 +215,7 @@ public function get_raw_embed_dataset() {
 			],
 
 			'remove_fb_root'             => [
-				'<div id="fb-root"></div><script async defer crossorigin="anonymous" src="https://connect.facebook.net/en_US/sdk.js#xfbml=1&version=v3.2"></script>', // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript
+				'<div id="fb-root"></div>' . str_repeat( '<script async defer crossorigin="anonymous" src="https://connect.facebook.net/en_US/sdk.js#xfbml=1&version=v3.2"></script>', 5 ), // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript
 				'',
 			],
 		];