Exclude data-ampdevmode attribute exclusion rule

Author: westonruter

bin/amphtml-update.py

@@ -680,6 +680,13 @@ def GetAttrs(attrs):
 
 		if value_dict is not None:
 
+			# Skip rules for dev mode attributes since the AMP plugin will allow them to pass through.
+			# See <https://github.com/ampproject/amphtml/pull/27174#issuecomment-601391161> for how the rules are
+			# defined in a way that they can never be satisfied, and thus to make the attribute never allowed.
+			# This runs contrary to the needs of the AMP plugin, as the internal sanitizers are built to ignore them.
+			if 'data-ampdevmode' == attr_spec.name:
+				continue
+
 			# Normalize bracketed amp-bind attribute syntax to data-amp-bind-* syntax.
 			name = attr_spec.name
 			if name[0] == '[':

includes/sanitizers/class-amp-allowed-tags-generated.php

@@ -5153,12 +5153,6 @@ class AMP_Allowed_Tags_Generated {
 		'amp-script' => array(
 			array(
 				'attr_spec_list' => array(
-					'data-ampdevmode' => array(
-						'blacklisted_value_regex' => 'false',
-						'value' => array(
-							'false',
-						),
-					),
 					'max-age' => array(
 						'value_regex' => '[0-9]+',
 					),

tests/php/test-tag-and-attribute-sanitizer.php

@@ -2143,7 +2143,7 @@ static function() {
 
 			'amp-script-5'                                 => [
 				'
-					<amp-script script="myScript" layout="container"></amp-script>
+					<amp-script script="myScript" layout="container" data-ampdevmode></amp-script>
 					<script type="text/plain" target="amp-script" id="myScript">
 					document.body.textContent += \'Hello world!\';
 					</script>