Skip to content

Commit 7041680

Browse files
committed
Improve reliability of AMP_Facebook_Embed_Test::test__raw_embed_sanitizer
1 parent efbad91 commit 7041680

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tests/php/test-amp-facebook-embed.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,16 +131,12 @@ public function get_raw_embed_dataset() {
131131
'post_with_fallbacks' => [
132132
'
133133
<div class="fb-post" data-href="https://www.facebook.com/20531316728/posts/10154009990506729/" data-width="500" data-show-text="true">
134-
<blockquote cite="https://developers.facebook.com/20531316728/posts/10154009990506729/" class="fb-xfbml-parse-ignore">
135-
Posted by <a href="https://www.facebook.com/facebook/">Facebook</a> on <a href="https://developers.facebook.com/20531316728/posts/10154009990506729/">Thursday, August 27, 2015</a>
136-
</blockquote>
134+
<blockquote cite="https://developers.facebook.com/20531316728/posts/10154009990506729/" class="fb-xfbml-parse-ignore"><!--blockquote_contents--></blockquote>
137135
</div>
138136
',
139137
'
140138
<amp-facebook width="500" height="400" data-href="https://www.facebook.com/20531316728/posts/10154009990506729/" data-show-text="true" data-embed-as="post" layout="responsive">
141-
<blockquote cite="https://developers.facebook.com/20531316728/posts/10154009990506729/" class="fb-xfbml-parse-ignore" fallback="">
142-
Posted by <a href="https://www.facebook.com/facebook/">Facebook</a> on <a href="https://developers.facebook.com/20531316728/posts/10154009990506729/">Thursday, August 27, 2015</a>
143-
</blockquote>
139+
<blockquote cite="https://developers.facebook.com/20531316728/posts/10154009990506729/" class="fb-xfbml-parse-ignore" fallback=""><!--blockquote_contents--></blockquote>
144140
</amp-facebook>
145141
',
146142
],
@@ -154,14 +150,14 @@ public function get_raw_embed_dataset() {
154150
'
155151
<div class="fb-page" data-href="https://www.facebook.com/xwp.co/" data-width="340" data-height="432" data-hide-cover="true" data-show-facepile="true" data-show-posts="false">
156152
<div class="fb-xfbml-parse-ignore">
157-
<blockquote cite="https://www.facebook.com/xwp.co/"><a href="https://www.facebook.com/xwp.co/">Like Us</a></blockquote>
153+
<blockquote cite="https://www.facebook.com/xwp.co/"><!--blockquote_contents--></blockquote>
158154
</div>
159155
</div>
160156
',
161157
'
162158
<amp-facebook-page width="340" height="432" data-href="https://www.facebook.com/xwp.co/" data-hide-cover="true" data-show-facepile="true" data-show-posts="false" layout="responsive">
163159
<div class="fb-xfbml-parse-ignore" fallback="">
164-
<blockquote cite="https://www.facebook.com/xwp.co/"><a href="https://www.facebook.com/xwp.co/">Like Us</a></blockquote>
160+
<blockquote cite="https://www.facebook.com/xwp.co/"><!--blockquote_contents--></blockquote>
165161
</div>
166162
</amp-facebook-page>
167163
',
@@ -231,6 +227,9 @@ public function test__raw_embed_sanitizer( $source, $expected ) {
231227

232228
$content = AMP_DOM_Utils::get_content_from_dom( $dom );
233229

230+
// Normalize blockquote contents to account for editing of published posts or variability of localized datetime strings.
231+
$content = preg_replace( '#(<blockquote.*?>).+?(</blockquote>)#s', '$1<!--blockquote_contents-->$2', $content );
232+
234233
$this->assertEqualMarkup( $expected, $content );
235234
}
236235

0 commit comments

Comments
 (0)