Add test for amp-subscriptions and note what is lacking

westonruter · westonruter · commit da10be25c7d2 · 2020-03-17T18:24:25.000-07:00
diff --git a/includes/sanitizers/class-amp-tag-and-attribute-sanitizer.php b/includes/sanitizers/class-amp-tag-and-attribute-sanitizer.php
@@ -2224,7 +2224,7 @@ private function is_amp_allowed_tag( DOMElement $node ) {
 	 *
 	 * @since 0.5
 	 *
-	 * @todo It would be more robust if the the actual tag spec were looked up and then matched against the parent, but this is currently overkill.
+	 * @todo It would be more robust if the the actual tag spec were looked up (see https://github.com/ampproject/amp-wp/pull/3817) and then matched against the parent. This is needed to support the spec 'subscriptions script ciphertext'.
 	 *
 	 * @param DOMElement $node             Node.
 	 * @param string     $parent_spec_name Parent spec name, for example 'body' or 'form [method=post]'.
diff --git a/tests/php/test-tag-and-attribute-sanitizer.php b/tests/php/test-tag-and-attribute-sanitizer.php
@@ -2753,6 +2753,25 @@ public function get_html_data() {
 				null,
 				[],
 			],
+			'amp-subscriptions'                       => [
+				// @todo The <script ciphertext type="application/octet-stream">...</script> but it is not yet supported. Support depends on todo in \AMP_Tag_And_Attribute_Sanitizer::has_parent().
+				'
+					<html>
+						<head>
+							<meta charset="utf-8">
+							<script cryptokeys sha-256-hash type="application/json">{}</script>
+						</head>
+						<body>
+							<section subscriptions-section="content" encrypted swg_amp_cache_nonce="NONCE">
+								...
+							</section>
+							<span swg_amp_cache_nonce="NONCE"></span>
+						</body>
+					</html>
+				',
+				null,
+				[ 'amp-subscriptions' ],
+			],
 		];
 
 		$bad_dev_mode_document = sprintf(

Original file line number	Diff line number	Diff line change
`@@ -2224,7 +2224,7 @@ private function is_amp_allowed_tag( DOMElement $node ) {`
`2224`	`2224`	`*`
`2225`	`2225`	`* @since 0.5`
`2226`	`2226`	`*`
`2227`		`- * @todo It would be more robust if the the actual tag spec were looked up and then matched against the parent, but this is currently overkill.`
	`2227`	`+ * @todo It would be more robust if the the actual tag spec were looked up (see https://github.com/ampproject/amp-wp/pull/3817) and then matched against the parent. This is needed to support the spec 'subscriptions script ciphertext'.`
`2228`	`2228`	`*`
`2229`	`2229`	`* @param DOMElement $node Node.`
`2230`	`2230`	`* @param string $parent_spec_name Parent spec name, for example 'body' or 'form [method=post]'.`