Merge branch 'feature/5209-clipboard-friendly-errors' of github.com:ampproject/amp-wp into feature/5209-clipboard-friendly-errors

* 'feature/5209-clipboard-friendly-errors' of github.com:ampproject/amp-wp:
  Remove unnecessary aria-label
  Parse and re-stringify JSON data to prettify
  No need to pretty-print error details on the backend

Author: westonruter

assets/src/amp-validation/copy-to-clipboard-buttons.js

@@ -49,7 +49,7 @@ export function handleCopyToClipboardButtons() {
 	// eslint-disable-next-line no-new
 	clipboards.push( new Clipboard( 'button.single-url-detail-copy', {
 		text: ( btn ) => {
-			return btn.getAttribute( 'data-error-json' );
+			return JSON.stringify( JSON.parse( btn.getAttribute( 'data-error-json' ) ), null, '\t' );
 		},
 	} ) );
 

includes/validation/class-amp-validation-error-taxonomy.php

@@ -1613,7 +1613,7 @@ public static function get_error_details_json( $term ) {
 		$json['removed']  = (bool) ( (int) $term->term_group & self::ACCEPTED_VALIDATION_ERROR_BIT_MASK );
 		$json['reviewed'] = (bool) ( (int) $term->term_group & self::ACKNOWLEDGED_VALIDATION_ERROR_BIT_MASK );
 
-		return wp_json_encode( $json, JSON_PRETTY_PRINT );
+		return wp_json_encode( $json );
 	}
 
 	/**
@@ -1646,8 +1646,7 @@ public static function filter_tag_row_actions( $actions, WP_Term $tag ) {
 			);
 
 			$actions['copy'] = sprintf(
-				'<button type="button" aria-label="%s" class="single-url-detail-copy button-link" data-error-json="%s">%s</button>',
-				esc_attr__( 'Copy to clipboard', 'amp' ),
+				'<button type="button" class="single-url-detail-copy button-link" data-error-json="%s">%s</button>',
 				esc_attr( self::get_error_details_json( $term ) ),
 				esc_html__( 'Copy to clipboard', 'amp' )
 			);