Skip to content

Commit 1126759

Browse files
authored
Fix issue where GFP cookie is not being attached to AdSense ad requests. (#40284)
1 parent 30b73eb commit 1126759

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ import {ResponsiveState} from './responsive-state';
6161
import {getDefaultBootstrapBaseUrl} from '../../../src/3p-frame';
6262
import {insertAnalyticsElement} from '../../../src/extension-analytics';
6363
import {getMode} from '../../../src/mode';
64-
import {AmpA4A} from '../../amp-a4a/0.1/amp-a4a';
64+
import {AmpA4A, tryAddingCookieParams} from '../../amp-a4a/0.1/amp-a4a';
6565
import {AMP_SIGNATURE_HEADER} from '../../amp-a4a/0.1/signature-verifier';
6666
import {getAmpAdRenderOutsideViewport} from '../../amp-ad/0.1/concurrent-load';
6767

@@ -423,6 +423,7 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
423423
? gppSectionId
424424
: null,
425425
};
426+
tryAddingCookieParams(consentTuple, this.win, parameters);
426427

427428
const experimentIds = [];
428429
return googleAdUrl(

extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,22 @@ describes.realWin(
652652
);
653653
});
654654

655+
it('should contain cookie params', () => {
656+
setCookie(env.win, '__gads', '__gads_val', Date.now() + 100_000);
657+
setCookie(env.win, '__gpi', '__gpi_val', Date.now() + 100_000);
658+
const ampStickyAd = createElementWithAttributes(doc, 'amp-sticky-ad', {
659+
'layout': 'nodisplay',
660+
});
661+
ampStickyAd.appendChild(element);
662+
doc.body.appendChild(ampStickyAd);
663+
return impl
664+
.getAdUrl({consentState: CONSENT_POLICY_STATE.SUFFICIENT})
665+
.then((adUrl) => {
666+
expect(adUrl).to.contain('cookie=__gads_val');
667+
expect(adUrl).to.contain('gpic=__gpi_val');
668+
});
669+
});
670+
655671
it('should contain act', () => {
656672
const ampStickyAd = createElementWithAttributes(doc, 'amp-sticky-ad', {
657673
'layout': 'nodisplay',

0 commit comments

Comments
 (0)