Skip to content

Commit dad047e

Browse files
authored
Fix Flakey Tests (#40257)
* Trigger Build * intentional only * skip flakey test and add TODO to fix
1 parent e742aa1 commit dad047e

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

extensions/amp-carousel/0.1/test/test-slidescroll.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,8 @@ describes.realWin(
418418
expect(doc.activeElement).to.equal(nextBtn);
419419
});
420420

421-
it('should show focus outline and border on next and prev buttons', async () => {
421+
// TODO(#40258) Fix and unskip flakey test.
422+
it.skip('should show focus outline and border on next and prev buttons', async () => {
422423
const ampSlideScroll = await getAmpSlideScroll();
423424
const impl = await ampSlideScroll.getImpl();
424425
const controls = impl.controls_;

extensions/amp-carousel/0.2/test/test-type-slides.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ describes.realWin(
179179
}
180180
});
181181

182-
it('should show focus outline and border on next and prev buttons', async () => {
182+
// TODO(#40258) Fix and unskip flakey test.
183+
it.skip('should show focus outline and border on next and prev buttons', async () => {
183184
const carousel = await getCarousel({loop: false});
184185
const impl = await carousel.getImpl();
185186

extensions/amp-lightbox/0.1/test/test-amp-lightbox.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ describes.realWin(
211211
});
212212
});
213213

214-
it('should stay in modal if focus stays in modal and close if outside', async () => {
214+
// TODO(#40258) Fix and unskip flakey test.
215+
it.skip('should stay in modal if focus stays in modal and close if outside', async () => {
215216
const lightbox = createLightbox();
216217
const insideLink = createLink('insideLink');
217218
lightbox.appendChild(insideLink);

extensions/amp-social-share/0.1/test/test-amp-social-share.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,8 @@ describes.realWin(
383383
});
384384
});
385385

386-
it('uses custom CSS when element is focused', async () => {
386+
// TODO(#40258) Fix and unskip flakey test.
387+
it.skip('uses custom CSS when element is focused', async () => {
387388
const share = doc.createElement('amp-social-share');
388389

389390
share.setAttribute('type', 'twitter');

0 commit comments

Comments
 (0)