Fix GFP cookie header processing iteration logic. (#40290)

* Fix GFP cookie header processing iteration logic.

* Unit test fixes.

* Remove unused underscores.

* Lint fix.

---------

Co-authored-by: erwin mombay <[email protected]>
(cherry picked from commit 23942ea)

Author: glevitzky

ads/google/a4a/cookie-utils.js

@@ -32,16 +32,18 @@ export function maybeSetCookieFromAdResponse(win, fetchResponse) {
   try {
     cookiesToSet = JSON.parse(
       fetchResponse.headers.get(AMP_GFP_SET_COOKIES_HEADER_NAME)
-    );
+    )['cookie'];
   } catch {}
+  if (!Array.isArray(cookiesToSet)) {
+    return;
+  }
   for (const cookieInfo of cookiesToSet) {
-    const cookieName =
-      (cookieInfo['_version_'] ?? 1) === 2 ? '__gpi' : '__gads';
-    const value = cookieInfo['_value_'];
+    const cookieName = (cookieInfo['version'] ?? 1) === 2 ? '__gpi' : '__gads';
+    const value = cookieInfo['value'];
     // On proxy origin, we want cookies to be partitioned by subdomain to
     // prevent sharing across unrelated publishers, so we don't set a domain.
-    const domain = getProxySafeDomain(win, cookieInfo['_domain_']);
-    const expiration = Math.max(cookieInfo['_expiration_'], 0);
+    const domain = getProxySafeDomain(win, cookieInfo['domain']);
+    const expiration = Math.max(cookieInfo['expiration'], 0);
     setCookie(win, cookieName, value, expiration, {
       domain,
       secure: false,

ads/google/a4a/test/test-cookie-utils.js

@@ -18,27 +18,49 @@ describes.fakeWin('#maybeSetCookieFromAdResponse', {amp: true}, (env) => {
             return;
           }
 
-          return JSON.stringify([
-            {
-              '_version_': 1,
-              '_value_': 'val1',
-              '_domain_': 'foo.com',
-              '_expiration_': Date.now() + 100_000,
-            },
-            {
-              '_version_': 2,
-              '_value_': 'val2',
-              '_domain_': 'foo.com',
-              '_expiration_': Date.now() + 100_000,
-            },
-          ]);
+          return JSON.stringify({
+            'cookie': [
+              {
+                'version': 1,
+                'value': 'val1',
+                'domain': 'foo.com',
+                'expiration': Date.now() + 100_000,
+              },
+              {
+                'version': 2,
+                'value': 'val2',
+                'domain': 'foo.com',
+                'expiration': Date.now() + 100_000,
+              },
+            ],
+          });
         },
       },
     });
 
     expect(getCookie(env.win, '__gads')).to.equal('val1');
     expect(getCookie(env.win, '__gpi')).to.equal('val2');
   });
+
+  it('should not throw for malformed JSON', () => {
+    expect(
+      () =>
+        void maybeSetCookieFromAdResponse(env.win, {
+          headers: {
+            has: (header) => {
+              return header === AMP_GFP_SET_COOKIES_HEADER_NAME;
+            },
+            get: (header) => {
+              if (header !== AMP_GFP_SET_COOKIES_HEADER_NAME) {
+                return;
+              }
+
+              return JSON.stringify({});
+            },
+          },
+        })
+    ).not.to.throw();
+  });
 });
 
 describes.fakeWin('#handleCookieOptOutPostMessage', {amp: true}, (env) => {

extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js

@@ -1740,20 +1740,22 @@ describes.fakeWin(
               return;
             }
 
-            return JSON.stringify([
-              {
-                '_version_': 1,
-                '_value_': 'val1',
-                '_domain_': 'foo.com',
-                '_expiration_': Date.now() + 100_000,
-              },
-              {
-                '_version_': 2,
-                '_value_': 'val2',
-                '_domain_': 'foo.com',
-                '_expiration_': Date.now() + 100_000,
-              },
-            ]);
+            return JSON.stringify({
+              'cookie': [
+                {
+                  'version': 1,
+                  'value': 'val1',
+                  'domain': 'foo.com',
+                  'expiration': Date.now() + 100_000,
+                },
+                {
+                  'version': 2,
+                  'value': 'val2',
+                  'domain': 'foo.com',
+                  'expiration': Date.now() + 100_000,
+                },
+              ],
+            });
           },
         },
       });

extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js

@@ -1919,20 +1919,22 @@ for (const {config, name} of [
                   return;
                 }
 
-                return JSON.stringify([
-                  {
-                    '_version_': 1,
-                    '_value_': 'val1',
-                    '_domain_': 'foo.com',
-                    '_expiration_': Date.now() + 100_000,
-                  },
-                  {
-                    '_version_': 2,
-                    '_value_': 'val2',
-                    '_domain_': 'foo.com',
-                    '_expiration_': Date.now() + 100_000,
-                  },
-                ]);
+                return JSON.stringify({
+                  'cookie': [
+                    {
+                      'version': 1,
+                      'value': 'val1',
+                      'domain': 'foo.com',
+                      'expiration': Date.now() + 100_000,
+                    },
+                    {
+                      'version': 2,
+                      'value': 'val2',
+                      'domain': 'foo.com',
+                      'expiration': Date.now() + 100_000,
+                    },
+                  ],
+                });
               },
             },
           });