✨ Playwire AMP-AD implementation #40437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tcreamer1
force-pushed
the
playwire-amp
branch
from
3cf3f7f to
a84eb8b
Compare
Member
|
@powerivq could you take a look at this |
powerivq
approved these changes
Dec 1, 2025
Contributor
|
please rebase against latest main branch. Tests are probably failing due to this. |
Contributor
Author
@powerivq done. Any other suggestions for the failing tests? |
Contributor
Author
|
@powerivq Tests also pass locally. Not sure what I can do next to keep this moving. |
Contributor
|
@tcreamer1 plz try rebasing again. it should work this time. |
Contributor
Author
|
Passing, thank you @powerivq ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwire is dedicated to helping publishers, creators, and app developers accelerate their business by amplifying ad revenue and operating more efficiently.
This adds Playwire as a new amp ad vendor.