Remove etag on /amppkg/cert URL. (#322)

twifkak · web-flow · commit 31ac32e89f24 · 2019-06-19T09:39:58.000-07:00
It is incorrect, since it contains only the certName, but the cert
contents vary when the OCSP response is updated. This is conflicting
with caching intermediaries.
diff --git a/packager/certcache/certcache.go b/packager/certcache/certcache.go
@@ -169,7 +169,6 @@ func (this *CertCache) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
 			expiry = 0
 		}
 		resp.Header().Set("Cache-Control", "public, max-age="+strconv.Itoa(expiry))
-		resp.Header().Set("ETag", "\""+this.certName+"\"")
 		resp.Header().Set("X-Content-Type-Options", "nosniff")
 		cbor, err := this.createCertChainCBOR(ocsp)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,6 @@ func (this CertCache) ServeHTTP(resp http.ResponseWriter, req http.Request) {`
`169`	`169`	`expiry = 0`
`170`	`170`	`}`
`171`	`171`	`resp.Header().Set("Cache-Control", "public, max-age="+strconv.Itoa(expiry))`
`172`		`- resp.Header().Set("ETag", "\""+this.certName+"\"")`
`173`	`172`	`resp.Header().Set("X-Content-Type-Options", "nosniff")`
`174`	`173`	`cbor, err := this.createCertChainCBOR(ocsp)`
`175`	`174`	`if err != nil {`