Move from Travis to GH actions (#505)

banaag · web-flow · commit 45dde2b64c2e · 2021-03-09T17:36:23.000-08:00
Use Go 1.16 Fix transformer_test mutex vet error. Fixes #504
diff --git a/.github/workflows/prerequisites.yml b/.github/workflows/prerequisites.yml
@@ -0,0 +1,54 @@
+name: Check prerequisites
+on: [push, pull_request]
+jobs:
+  check-format:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Setup Go 1.16
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.16'
+
+    - name: Install goimports
+      run: go get golang.org/x/tools/cmd/goimports
+
+    - name: Checkout the repository
+      uses: actions/checkout@v2
+
+# Comment this out for now until amppackager passes goimports.
+# https://github.com/ampproject/amppackager/issues/506
+#    - name: Check formatting with goimports
+#      run: |
+#      if $(go env GOPATH)/bin/goimports -d . | grep . ; then
+#          exit 1
+#      fi
+
+  go-vet:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Setup Go 1.16
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.16'
+
+    - name: Checkout the repository
+      uses: actions/checkout@v2
+
+    - name: Diagnose the code with go vet
+      # TODO(banaag): Turn on composite checking when
+      # https://github.com/ampproject/amppackager/issues/507 is fixed.
+      run: go vet -composites=false ./...
+
+  go-test:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Setup Go 1.16
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.16'
+
+    - name: Checkout the repository
+      uses: actions/checkout@v2
+
+    - name: Run the tests
+      run: go test ./...
diff --git a/.travis.yml b/.travis.yml
diff --git a/transformer/transformer_test.go b/transformer/transformer_test.go
@@ -309,8 +309,8 @@ func TestCustom(t *testing.T) {
 }
 
 func TestCustomFail(t *testing.T) {
-	r := rpb.Request{Html: "<html ⚡><lemur>", Config: rpb.Request_CUSTOM, Transformers: []string{"does_not_exist"}}
-	if html, _, err := Process(&r); err == nil {
+	r := &rpb.Request{Html: "<html ⚡><lemur>", Config: rpb.Request_CUSTOM, Transformers: []string{"does_not_exist"}}
+	if html, _, err := Process(r); err == nil {
 		t.Fatalf("Process(%v) = %s, nil; want error", r, html)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -309,8 +309,8 @@ func TestCustom(t *testing.T) {`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`func TestCustomFail(t *testing.T) {`
`312`		`- r := rpb.Request{Html: "<html ⚡><lemur>", Config: rpb.Request_CUSTOM, Transformers: []string{"does_not_exist"}}`
`313`		`- if html, _, err := Process(&r); err == nil {`
	`312`	`+ r := &rpb.Request{Html: "<html ⚡><lemur>", Config: rpb.Request_CUSTOM, Transformers: []string{"does_not_exist"}}`
	`313`	`+ if html, _, err := Process(r); err == nil {`
`314`	`314`	`t.Fatalf("Process(%v) = %s, nil; want error", r, html)`
`315`	`315`	`}`
`316`	`316`	`}`