Literal Computed Key Transform was grabbing info that didnt exist for all nodes before its safeguard

Author: kristoferbaxter

src/transformers/literal-computed-keys.ts

@@ -41,10 +41,10 @@ export default class LiteralComputedKeys extends Transform {
     walk.simple(program, {
       ObjectExpression(node: ObjectExpression) {
         for (const property of node.properties) {
-          const [propertyStart]: Range = property.range as Range;
-          const [valueStart]: Range = property.value.range as Range;
-
           if (property.computed && property.key.type === 'Literal') {
+            const [propertyStart]: Range = property.range as Range;
+            const [valueStart]: Range = property.value.range as Range;
+
             source.overwrite(
               propertyStart,
               valueStart,

test/literal-computed-keys/fixtures/spread-expression.esm.advanced.js

@@ -0,0 +1 @@
+let a=["put","add","delete","clear"];export function SpreadExpression(){return Object.assign({},a,{get:()=>console.log("get thing")})};

test/literal-computed-keys/fixtures/spread-expression.esm.default.js

@@ -0,0 +1 @@
+let a=["put","add","delete","clear"];export function SpreadExpression(){return{...a,get:()=>console.log("get thing")}};

test/literal-computed-keys/fixtures/spread-expression.esm.es5.js

@@ -0,0 +1 @@
+var a=["put","add","delete","clear"];export function SpreadExpression(){return Object.assign({},a,{get:function(){return console.log("get thing")}})};

test/literal-computed-keys/fixtures/spread-expression.js

@@ -0,0 +1,8 @@
+const A = ['put', 'add', 'delete', 'clear'];
+
+export function SpreadExpression(yep) {
+  return {
+    ...A,
+    get: (thing) => console.log('get thing'),
+  }
+}

test/literal-computed-keys/spread-expression.test.js

@@ -0,0 +1,19 @@
+/**
+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { generator } from '../generator';
+
+generator('literal-computed-keys', 'spread-expression');