Expand Test Coverage (#262)

kristoferbaxter · web-flow · commit 81c79bec073c · 2019-12-27T17:13:39.000-08:00
* functions exported with arguments

* Test for strict removal

* Test for removing strict declaration on mjs output when the output is an iife.
diff --git a/test/export-named/fixtures/multiple.esm.advanced.js b/test/export-named/fixtures/multiple.esm.advanced.js
@@ -1 +1 @@
-function bar(){console.log(1)};var foo=1;export{bar,foo};
+function bar(){console.log(1)};function baz(a){console.log(a)};var foo=1;export{bar,baz,foo};
diff --git a/test/export-named/fixtures/multiple.esm.default.js b/test/export-named/fixtures/multiple.esm.default.js
@@ -1 +1 @@
-function bar(){console.log(1)};var foo=1;export{bar,foo};
+function bar(){console.log(1)};function baz(a){console.log(a)};var foo=1;export{bar,baz,foo};
diff --git a/test/export-named/fixtures/multiple.esm.es5.js b/test/export-named/fixtures/multiple.esm.es5.js
@@ -1 +1 @@
-function bar(){console.log(1)};var foo=1;export{bar,foo};
+function bar(){console.log(1)};function baz(a){console.log(a)};var foo=1;export{bar,baz,foo};
diff --git a/test/export-named/fixtures/multiple.js b/test/export-named/fixtures/multiple.js
@@ -2,4 +2,7 @@ const foo = 1;
 const bar = function() {
   console.log(foo);
 }
-export{foo, bar};
+const baz = function(name) {
+  console.log(name);
+}
+export{foo, bar, baz};
diff --git a/test/strict-removal/fixtures/mjs-suffix.iife.default.mjs b/test/strict-removal/fixtures/mjs-suffix.iife.default.mjs
@@ -0,0 +1 @@
+var modular=function(a){a.thing=1;return a}({});
diff --git a/test/strict-removal/fixtures/mjs-suffix.mjs b/test/strict-removal/fixtures/mjs-suffix.mjs
@@ -0,0 +1,3 @@
+'use strict';
+
+export const thing = 1;
diff --git a/test/strict-removal/fixtures/top-level.esm.advanced.js b/test/strict-removal/fixtures/top-level.esm.advanced.js
@@ -0,0 +1 @@
+export var thing=1;
diff --git a/test/strict-removal/fixtures/top-level.esm.default.js b/test/strict-removal/fixtures/top-level.esm.default.js
@@ -0,0 +1 @@
+export var thing=1;
diff --git a/test/strict-removal/fixtures/top-level.esm.es5.js b/test/strict-removal/fixtures/top-level.esm.es5.js
@@ -0,0 +1 @@
+export var thing=1;
diff --git a/test/strict-removal/fixtures/top-level.js b/test/strict-removal/fixtures/top-level.js
@@ -0,0 +1,3 @@
+'use strict';
+
+export const thing = 1;
diff --git a/test/strict-removal/mjs-suffix.test.js b/test/strict-removal/mjs-suffix.test.js
@@ -0,0 +1,55 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const test = require('ava');
+const { default: compiler } = require('../../transpile/index');
+const rollup = require('rollup');
+const fs = require('fs');
+const path = require('path');
+
+test('remove strict declaration from .mjs input', async t => {
+  const bundle = await rollup.rollup({
+    input: 'test/strict-removal/fixtures/mjs-suffix.mjs',
+    plugins: [compiler()],
+    onwarn: _ => null,
+  });
+
+  const bundles = await bundle.generate({
+    format: 'iife',
+    name: 'modular',
+    sourcemap: true,
+    file: 'mjs-suffix.iife.default.mjs'
+  });
+
+  const output = [];
+  if (bundles.output) {
+    for (const file in bundles.output) {
+      const minified = await fs.promises.readFile(
+        path.join('test/strict-removal/fixtures/mjs-suffix.iife.default.mjs'),
+        'utf8',
+      );
+      output.push({
+        minified,
+        code: bundles.output[file].code,
+      });
+    }
+  }
+
+  t.plan(output.length);
+  for (const result of output) {
+    t.is(result.code, result.minified);
+  }
+});
diff --git a/test/strict-removal/top-level.test.js b/test/strict-removal/top-level.test.js
@@ -0,0 +1,19 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {generator} from '../generator';
+
+generator('strict-removal', 'top-level');

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-function bar(){console.log(1)};var foo=1;export{bar,foo};`
	`1`	`+function bar(){console.log(1)};function baz(a){console.log(a)};var foo=1;export{bar,baz,foo};`
Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,7 @@ const foo = 1;`
`2`	`2`	`const bar = function() {`
`3`	`3`	`console.log(foo);`
`4`	`4`	`}`
`5`		`-export{foo, bar};`
	`5`	`+const baz = function(name) {`
	`6`	`+ console.log(name);`
	`7`	`+}`
	`8`	`+export{foo, bar, baz};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var modular=function(a){a.thing=1;return a}({});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+'use strict';`
	`2`	`+`
	`3`	`+export const thing = 1;`