Skip to content

Commit a586dee

Browse files
Additional cleanups
1 parent 6d706bb commit a586dee

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

src/transformers/literal-computed-keys.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { Transform } from '../types';
17+
import { Transform, Range } from '../types';
1818
import { TransformSourceDescription } from 'rollup';
1919
import MagicString from 'magic-string';
2020
import { ObjectExpression } from 'estree';
@@ -40,21 +40,18 @@ export default class LiteralComputedKeys extends Transform {
4040

4141
walk.simple(program, {
4242
ObjectExpression(node: ObjectExpression) {
43-
const properties = node.properties;
44-
properties.forEach(property => {
45-
if (
46-
property.computed &&
47-
property.key.type === 'Literal' &&
48-
property.range &&
49-
property.value.range
50-
) {
43+
for (const property of node.properties) {
44+
const [propertyStart]: Range = property.range as Range;
45+
const [valueStart]: Range = property.value.range as Range;
46+
47+
if (property.computed && property.key.type === 'Literal') {
5148
source.overwrite(
52-
property.range[0],
53-
property.value.range[0],
49+
propertyStart,
50+
valueStart,
5451
`${property.key.value}${property.value.type !== 'FunctionExpression' ? ':' : ''}`,
5552
);
5653
}
57-
});
54+
}
5855
},
5956
});
6057

src/transformers/strict.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { Transform } from '../types';
17+
import { Transform, Range } from '../types';
1818
import { isESMFormat } from '../options';
1919
import { TransformSourceDescription } from 'rollup';
2020
import MagicString from 'magic-string';
@@ -41,8 +41,10 @@ export default class StrictTransform extends Transform {
4141
walk.simple(program, {
4242
ExpressionStatement(node: ExpressionStatement) {
4343
const { type, value } = node.expression as SimpleLiteral;
44-
if (type === 'Literal' && value === 'use strict' && node.range) {
45-
source.remove(...node.range);
44+
const range: Range = node.range as Range;
45+
46+
if (type === 'Literal' && value === 'use strict') {
47+
source.remove(...range);
4648
}
4749
},
4850
});

0 commit comments

Comments
 (0)