Introduce TSLint (#3)

* Introduce TSLint + rules matching AMP Project
* Remove dist from git

Author: kristoferbaxter

.gitignore

@@ -2,4 +2,5 @@ node_modules/*
 yarn.lock
 yarn-error.log
 .vscode/*
-.DS_Store
+.DS_Store
+dist/

dist/index.js

@@ -19,7 +19,8 @@
   "scripts": {
     "pretest": "yarn build",
     "test": "ava test/*.js",
-    "build": "rimraf dist && tsc -p tsconfig.json"
+    "build": "rimraf dist && tsc -p tsconfig.json",
+    "lint": "tslint -c tslint.json -p tsconfig.json"
   },
   "dependencies": {
     "google-closure-compiler": "^20180610.0.2",
@@ -35,18 +36,20 @@
     "rimraf": "^2.6.2",
     "rollup": "^0.62.0",
     "sourcemap-validator": "^1.1.0",
+    "tslint": "5.10.0",
     "typescript": "^2.9.2"
   },
   "lint-staged": {
     "*.ts": [
+      "yarn lint --fix",
       "prettier --config .prettierrc --write",
       "git add"
     ]
   },
   "husky": {
     "hooks": {
-      "pre-commit": "lint-staged",
-      "pre-push": "yarn test"
+      "pre-push": "yarn test",
+      "pre-commit": "lint-staged"
     }
   }
 }

dist/index.js.map

@@ -19,7 +19,7 @@ import { sync } from 'temp-write';
 import { readFileSync } from 'fs';
 import { OutputOptions, RawSourceMap, Plugin } from 'rollup';
 
-export function defaultCompileOptions(outputOptions: OutputOptions): CompileOptions {
+export const defaultCompileOptions = (outputOptions: OutputOptions): CompileOptions => {
   // Defaults for Rollup Projects are slightly different than Closure Compiler defaults.
   // - Users of Rollup tend to transpile their code before handing it to a minifier,
   // so no transpile is default.
@@ -28,7 +28,7 @@ export function defaultCompileOptions(outputOptions: OutputOptions): CompileOpti
   // - When Rollup is configured to output an iife, ensure Closure Compiler does not
   // mangle the name of the iife wrapper.
 
-  let options: CompileOptions = {
+  const options: CompileOptions = {
     language_out: 'NO_TRANSPILE',
     assume_function_wrapper: outputOptions.format === 'es' ? true : false,
     warning_level: 'QUIET',
@@ -43,10 +43,10 @@ export function defaultCompileOptions(outputOptions: OutputOptions): CompileOpti
 export default function closureCompiler(compileOptions: CompileOptions = {}): Plugin {
   return {
     name: 'closure-compiler',
-    transformBundle: function(
+    transformBundle: (
       code: string,
       outputOptions: OutputOptions,
-    ): Promise<{ code: string; map: RawSourceMap } | void> {
+    ): Promise<{ code: string; map: RawSourceMap } | void> => {
       const temp = {
         js: sync(code),
         map: sync(''),
@@ -57,12 +57,12 @@ export default function closureCompiler(compileOptions: CompileOptions = {}): Pl
         create_source_map: temp.map,
       });
 
-      const compile: Promise<string> = new Promise(function(resolve, reject) {
-        new compiler(compileOptions).run(function(
+      const compile: Promise<string> = new Promise((resolve, reject) => {
+        new compiler(compileOptions).run((
           exitCode: number,
           stdOut: string,
           stdErr: string,
-        ) {
+        ) => {
           if (exitCode !== 0) {
             reject(new Error(`Google Closure Compiler exit ${exitCode}: ${stdErr}`));
           } else {

package.json

@@ -0,0 +1,36 @@
+{
+  "rules": {
+    "variable-name": [
+      true, 
+      "ban-keywords",
+      "check-format",
+      "allow-trailing-underscore",
+      "allow-leading-underscore"
+    ],
+    "triple-equals": [true, "allow-null-check"],
+    "prefer-const": true,
+    "use-isnan": true,
+    "radix": true,
+    "only-arrow-functions": [true, "allow-declarations", "allow-named-functions"],
+    "object-literal-shorthand": true,
+    "no-debugger": true,
+    "no-duplicate-variable": true,
+    "no-eval": true,
+    "no-string-throw": true,
+    "no-unused-expression": true,
+    "no-var-keyword": true,
+    "ban": [
+      true,
+      "alert",
+      {"name": "parseInt", "message": "tsstyle#type-coercion"},
+      {"name": "parseFloat", "message": "tsstyle#type-coercion"},
+      {"name": "Array", "message": "tsstyle#array-constructor"}
+    ],
+    "ban-types": [true,
+      ["Object", "Use {} instead."],
+      ["String", "Use 'string' instead."],
+      ["Number", "Use 'number' instead."],
+      ["Boolean", "Use 'boolean' instead."]
+    ]
+  }
+}