Skip to content

There are APIs where ResponseAfter is not called #36

@katonium

Description

@katonium

Hello, thank you for the useful SDK.
I think there may be some APIs where ResponseAfter is not called.

example 1: https://github.com/amzapi/selling-partner-api-sdk/blob/master/fees/api.gen.go#L179

func (c *Client) GetMyFeesEstimateForASIN(ctx context.Context, asin string, body GetMyFeesEstimateForASINJSONRequestBody) (*http.Response, error) {
	req, err := NewGetMyFeesEstimateForASINRequest(c.Endpoint, asin, body)
	if err != nil {
		return nil, err
	}
	req = req.WithContext(ctx)
	if c.RequestBefore != nil {
		err = c.RequestBefore(ctx, req)
		if err != nil {
			return nil, err
		}
	}
	return c.Client.Do(req)
}

example 2: https://github.com/amzapi/selling-partner-api-sdk/blob/master/fbaOutbound/api.gen.go#L373

func (c *Client) GetFulfillmentPreview(ctx context.Context, body GetFulfillmentPreviewJSONRequestBody) (*http.Response, error) {
	req, err := NewGetFulfillmentPreviewRequest(c.Endpoint, body)
	if err != nil {
		return nil, err
	}
	req = req.WithContext(ctx)
	if c.RequestBefore != nil {
		err = c.RequestBefore(ctx, req)
		if err != nil {
			return nil, err
		}
	}
	return c.Client.Do(req)
}

I don't know why this happens because I think the code is automatically generated, but I think these are not the your intended implementation.
Please let me know if there is anything I can do to help fix it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions