Package.swift does not contain all dependencies

[PeterAdams-A]

Some versions of swift package manager react badly to missing dependencies in the swift package file.

For example -

SmokeHTTP1 uses SmokeOperations (here https://github.com/amzn/smoke-framework/blob/main/Sources/SmokeHTTP1/ChannelHTTP1ResponseHandler.swift#L21)

but there is no declared dependency (here

smoke-framework/Package.swift

Lines 59 to 65 in db13328

	name: "SmokeHTTP1", dependencies: [
	.product(name: "Logging", package: "swift-log"),
	.product(name: "NIO", package: "swift-nio"),
	.product(name: "NIOHTTP1", package: "swift-nio"),
	.product(name: "NIOFoundationCompat", package: "swift-nio"),
	.product(name: "NIOExtras", package: "swift-nio-extras"),
	.target(name: "SmokeInvocation"),

)

[tachyonics]

Hi Peter, sorry for the delay. Looks like this was a miss. Is there any systematic way to detect such issues and any other instances where this has happened?

Thanks,
Simon

[Davidde94]

@tachyonics Swift Package Manager are working on a fix, tracked here https://bugs.swift.org/browse/SR-1393