Skip to content

Commit 5133598

Browse files
Merge pull request #575 from Anaconda-Platform/tech/AC-87/bump_version_to_1_8_0
AC-87: Fixes and version bump to 1.8.0
2 parents dc47ad8 + c905b8b commit 5133598

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎binstar_client/__about__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44

55
__all__ = ['__version__']
66

7-
__version__ = '1.8.0rc2'
7+
__version__ = '1.8.0'

‎binstar_client/requests_ext.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,13 @@ def tell(self):
121121

122122
def seek(self, pos, mode=0):
123123
assert pos == 0
124-
if mode is 0:
124+
if mode == 0:
125125
self.to_read = self.have_read + self.to_read
126126
self.have_read = []
127127
[fd.seek(pos, mode) for fd in self.to_read]
128128
self.cursor = 0
129129

130-
elif mode is 2:
130+
elif mode == 2:
131131
self.have_read = self.have_read + self.to_read
132132
self.to_read = []
133133
[fd.seek(pos, mode) for fd in self.have_read]

‎binstar_client/utils/notebook/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def has_environment(nb_file):
4545
data = fb.read()
4646
nb = nbformat.reader.reads(data)
4747
return 'environment' in nb['metadata']
48-
except (AttributeError, KeyError):
48+
except (ValueError, AttributeError, KeyError):
4949
return False
5050
except (IOError, nbformat.reader.NotJSONError):
5151
return False

0 commit comments

Comments
 (0)