Skip to content

passing RendererType.CONDA to render.recipe.render function causes TypeError #169

@onurbingol

Description

@onurbingol
  File "/Users/obingol/projects/anaconda/percy/percy/render/recipe.py", line 1145, in render
    for s, p in list(itertools.product(subdir, python)):
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/obingol/projects/anaconda/percy/percy/render/recipe.py", line 1250, in render_feedstock
    ret = render(**kws)
          ^^^^^^^^^^^^^
  File "/Users/obingol/projects/anaconda/percy/.private/percy_stuff.py", line 12, in <module>
    feedstock_path=fs_path,
    subdir=subdir,
    python=python,
    others=others,
    return_exceptions=True,
    renderer=RendererType.CONDA
)
           
TypeError: 'NoneType' object is not iterable

subdir = None which is also the default value on the function signature. Documentation indicates if subdir = None is passed, it renders all subdirs.

Possible fix:

    # inside render.recipe.render function
    else:
        variants = []
        if not python:
            python = ["3.9", "3.10", "3.11", "3.12", "3.13"]
        if not subdir:
             subdir = ["win-64", "linux-64", "linux-aarch64"]
        for s, p in list(itertools.product(subdir, python)):

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions