Skip to content

Commit e7fe59b

Browse files
outman119gastmaier
authored andcommitted
iio: adc: ad4062: Replace IRQF_ONESHOT with IRQF_NO_THREAD
In ad4062_request_irq(), when request irq for "gp1", the code uses IRQF_ONESHOT flag, which is not appropriate for a primary handler that does not have a secondary threaded handler. And since commit aef30c8 ("genirq: Warn about using IRQF_ONESHOT without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag in IRQ request and gives a warning if there is no threaded handler. Since there is no threaded handler, replace devm_request_threaded_irq with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD. Also remove an extraneous semicolon at the end of ad4062_write_raw_dispatch(). Found by code review, compile pass. Fixes: d528440 ("iio: adc: Add support for ad4062") Signed-off-by: Felix Gu <ustc.gu@gmail.com> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> (cherry picked from commit 20c2a46)
1 parent 2a4813d commit e7fe59b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/iio/adc/ad4062.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -719,10 +719,8 @@ static int ad4062_request_irq(struct iio_dev *indio_dev)
719719
}
720720
st->gpo_irq[1] = true;
721721

722-
return devm_request_threaded_irq(dev, ret,
723-
ad4062_irq_handler_drdy,
724-
NULL, IRQF_ONESHOT, indio_dev->name,
725-
indio_dev);
722+
return devm_request_irq(dev, ret, ad4062_irq_handler_drdy,
723+
IRQF_NO_THREAD, indio_dev->name, indio_dev);
726724
}
727725

728726
static const struct iio_trigger_ops ad4062_trigger_ops = {
@@ -964,7 +962,7 @@ static int ad4062_write_raw_dispatch(struct ad4062_state *st, int val, int val2,
964962
default:
965963
return -EINVAL;
966964
}
967-
};
965+
}
968966

969967
static int ad4062_write_raw(struct iio_dev *indio_dev,
970968
struct iio_chan_spec const *chan, int val,

0 commit comments

Comments
 (0)