Skip to content

Commit 50169ba

Browse files
crsz20EricB-ADI
authored andcommitted
fix(BLE): Resolve double increment of memory management in LlInitSetRtCfg (#1237)
1 parent 2dcfb68 commit 50169ba

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

.github/workflows/BLE_Examples_Test.yml

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -595,8 +595,6 @@ jobs:
595595
boards: |
596596
max32655_board1
597597
max32655_board2
598-
max32665_board1
599-
max32690_board_w1
600598
lock: true
601599
timeout: 3600 # Attempt to lock for an hour
602600

@@ -615,23 +613,21 @@ jobs:
615613
# sed -i "s/'S'/'!'/g" Examples/MAX32690/Bluetooth/BLE_otac/datc_main.c
616614
617615
- name: Erase Boards DATS
618-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32665_DATS_CONNECTED_TEST == 'true' || env.MAX32690_DATS_CONNECTED_TEST == 'true'}}
616+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
619617
uses: Analog-Devices-MSDK/btm-ci-scripts/actions/[email protected]
620618
with:
621619
board: |
622620
max32655_board1
623621
max32655_board2
624-
max32665_board1
625-
max32690_board_w1
626622
627623
has_two_flash_banks: |
628624
true
629625
true
630-
true
631-
true
626+
# true
627+
# true
632628
633629
- name: Flash DATS 655
634-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true'}}
630+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
635631
uses: Analog-Devices-MSDK/btm-ci-scripts/actions/[email protected]
636632
with:
637633
board: |
@@ -652,7 +648,7 @@ jobs:
652648
distclean: true
653649

654650
- name: DATS 655
655-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true'}}
651+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
656652
run: |
657653
DATS_TEST_DIR=$TEST_DIR/dats
658654
DATS_BOARD_655=max32655_board1
@@ -662,17 +658,15 @@ jobs:
662658
663659
664660
- name: Erase Boards OTAS
665-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32665_DATS_CONNECTED_TEST == 'true' || env.MAX32690_DATS_CONNECTED_TEST == 'true'}}
661+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
666662
uses: Analog-Devices-MSDK/btm-ci-scripts/actions/[email protected]
667663
with:
668664
board: |
669665
max32655_board1
670666
max32655_board2
671-
max32665_board1
672-
max32690_board_w1
673667
674668
- name: Flash OTAS
675-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32665_DATS_CONNECTED_TEST == 'true' || env.MAX32690_DATS_CONNECTED_TEST == 'true'}}
669+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
676670
uses: Analog-Devices-MSDK/btm-ci-scripts/actions/[email protected]
677671
with:
678672
board: |
@@ -695,13 +689,13 @@ jobs:
695689
distclean: true
696690

697691
- name: OTAS
698-
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32665_DATS_CONNECTED_TEST == 'true' || env.MAX32690_DATS_CONNECTED_TEST == 'true'}}
692+
if: ${{env.MAX32655_DATS_CONNECTED_TEST == 'true' || env.MAX32655_RUN_ALL_TEST == 'true'}}
699693
run: |
700694
OTAS_TEST_DIR=$TEST_DIR/otas
701695
OTAS_BOARD_655=max32655_board1
702696
OTAC_BOARD_655=max32655_board2
703-
OTAC_BOARD_665=max32665_board1
704-
OTAC_BOARD_690=max32690_board_w1
697+
# OTAC_BOARD_665=max32665_board1
698+
# OTAC_BOARD_690=max32690_board_w1
705699
706700
707701
if [[ $MAX32655_OTAS_CONNECTED_TEST == 'true' ]]; then

Libraries/Cordio/controller/sources/ble/init/init.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,16 +319,22 @@ uint32_t LlInitSetLlRtCfg(const LlRtCfg_t *pLlRtCfg, uint8_t *pFreeMem, uint32_t
319319
/*************************************************************************************************/
320320
uint32_t LlInitSetRtCfg(LlInitRtCfg_t *pCfg)
321321
{
322-
uint32_t memUsed = LlInitSetBbRtCfg(pCfg->pBbRtCfg, pCfg->wlSizeCfg, pCfg->rlSizeCfg, pCfg->plSizeCfg,
322+
uint32_t totalMemUsed = 0;
323+
uint32_t memUsed;
324+
325+
memUsed = LlInitSetBbRtCfg(pCfg->pBbRtCfg, pCfg->wlSizeCfg, pCfg->rlSizeCfg, pCfg->plSizeCfg,
323326
pCfg->pFreeMem, pCfg->freeMemAvail);
327+
324328
pCfg->pFreeMem += memUsed;
325329
pCfg->freeMemAvail -= memUsed;
330+
totalMemUsed += memUsed;
326331

327-
memUsed += LlInitSetLlRtCfg(pCfg->pLlRtCfg, pCfg->pFreeMem, pCfg->freeMemAvail);
332+
memUsed = LlInitSetLlRtCfg(pCfg->pLlRtCfg, pCfg->pFreeMem, pCfg->freeMemAvail);
328333
pCfg->pFreeMem += memUsed;
329334
pCfg->freeMemAvail -= memUsed;
335+
totalMemUsed += memUsed;
330336

331-
return memUsed;
337+
return totalMemUsed;
332338
}
333339

334340
/*************************************************************************************************/

0 commit comments

Comments
 (0)