ad9371: unit test fixes

Signed-off-by: IonutMuthi <Ionut.Muthi@analog.com>

Author: IonutMuthi

js/testAutomations/ad9371/ad9371_Basic_Unit_test.js

@@ -2388,21 +2388,26 @@ TestFramework.runTest("UNIT.CAL.FULL_CALIBRATION_FLOW", function() {
         msleep(500);
 
         // Trigger calibration
-        ad9371.calibrate();
+        var calOk = ad9371.calibrate();
         msleep(2000);
 
-        // Verify flags still set
-        var rxQec = ad9371.getCalibrateRxQecEn();
-        var txQec = ad9371.getCalibrateTxQecEn();
-        printToConsole("  After calibrate: rx_qec=" + rxQec + " tx_qec=" + txQec);
-
-        // Restore
+        // Restore before any return path
         ad9371.setCalibrateRxQecEn(origRxQec);
         ad9371.setCalibrateTxQecEn(origTxQec);
         ad9371.setCalibrateTxLolEn(origTxLol);
         ad9371.setCalibrateTxLolExtEn(origTxLolExt);
         msleep(500);
 
+        if (!calOk) {
+            printToConsole("  FAIL: Calibration returned error from hardware");
+            return false;
+        }
+
+        // Verify flags still set after successful calibration
+        var rxQec = ad9371.getCalibrateRxQecEn();
+        var txQec = ad9371.getCalibrateTxQecEn();
+        printToConsole("  After calibrate: rx_qec=" + rxQec + " tx_qec=" + txQec);
+
         return true;
     } catch (e) {
         printToConsole("  Error: " + e);
@@ -2888,7 +2893,7 @@ TestFramework.runTest("UNIT.BADVAL.TX_LO_FREQUENCY", function() {
         printToConsole("  Wrote 0 MHz, read=" + readBack);
 
         // Should either clamp to min or reject — value should not be 0
-        var passed = (parseFloat(readBack) >= 300);
+        var passed = (parseFloat(readBack) >= 70);
         if (!passed) {
             printToConsole("  FAIL: TX LO accepted invalid frequency 0 MHz");
         }

packages/ad9371/plugins/ad9371plugin/include/ad9371plugin/ad9371_api.h

@@ -58,7 +58,7 @@ class SCOPY_AD9371PLUGIN_EXPORT Ad9371_API : public ApiObject
 	Q_INVOKABLE void setCalibrateClgcEn(const QString &val);
 	Q_INVOKABLE QString getCalibrateVswrEn();
 	Q_INVOKABLE void setCalibrateVswrEn(const QString &val);
-	Q_INVOKABLE void calibrate();
+	Q_INVOKABLE bool calibrate();
 
 	// --- RX Chain ---
 	Q_INVOKABLE QString getRxRfBandwidth();

packages/ad9371/plugins/ad9371plugin/src/ad9371_api.cpp

@@ -384,25 +384,27 @@ void Ad9371_API::setCalibrateVswrEn(const QString &v)
 	iio_device_attr_write_bool(tool->m_dev, "calibrate_vswr_en", v.toInt() != 0);
 }
 
-void Ad9371_API::calibrate()
+bool Ad9371_API::calibrate()
 {
 	// Direct IIO write — no widget for write-only trigger
 	ConnectionProvider *cp = ConnectionProvider::GetInstance();
 	Connection *conn = cp->open(m_plugin->m_param);
 	if(!conn) {
 		qWarning(CAT_AD9371_API) << "Failed to open connection for calibrate";
-		return;
+		return false;
 	}
 	iio_device *dev = iio_context_find_device(conn->context(), "ad9371-phy");
 	if(!dev) {
 		qWarning(CAT_AD9371_API) << "ad9371-phy device not found";
-		return;
+		return false;
 	}
 	int ret = iio_device_attr_write_bool(dev, "calibrate", true);
-	if(ret < 0)
+	if(ret < 0) {
 		qWarning(CAT_AD9371_API) << "Calibration failed:" << ret;
-	else
-		qDebug(CAT_AD9371_API) << "Calibration triggered";
+		return false;
+	}
+	qDebug(CAT_AD9371_API) << "Calibration triggered";
+	return true;
 }
 
 // --- RX Chain ---