Skip to content

Commit da9885d

Browse files
wip migration, squash this, adcplugin.cpp last partial modify
Signed-off-by: Andrei-Fabian-Pop <Andreifabian.Pop@analog.com>
1 parent 59c0ee7 commit da9885d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+458
-213
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ endif()
108108

109109
find_path(
110110
IIO_INCLUDE_DIRS
111-
NAMES iio.h
111+
NAMES iio/iio.h
112112
HINTS ${CMAKE_INSTALL_PREFIX}/include
113113
/include
114114
/usr/include

core/include/core/scopyhomeaddpage.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
#include "pluginmanager.h"
3131
#include "scopy-core_export.h"
3232

33-
#include <iio.h>
34-
3533
#include <QFuture>
3634
#include <QStackedWidget>
3735
#include <QWidget>

core/src/iiodeviceimpl.cpp

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121

2222
#include "iiodeviceimpl.h"
2323

24-
#include "iioutil/connectionprovider.h"
24+
#include <iioutil/connectionprovider.h>
25+
#include <iioutil/iiocpp/iioresult.h>
26+
#include <iioutil/iiocpp/iioattribute.h>
27+
#include <iioutil/iiocpp/iiocontext.h>
2528

2629
#include <QLoggingCategory>
2730

@@ -56,12 +59,16 @@ QMap<QString, QString> IIODeviceImpl::readDeviceInfo()
5659
if(!conn) {
5760
qWarning(CAT_IIO_DEVICEIMPL) << "Cannot read the device info! (unavailable context)";
5861
} else {
59-
for(int i = 0; i < iio_context_get_attrs_count(conn->context()); i++) {
60-
const char *name;
61-
const char *value;
62-
int ret = iio_context_get_attr(conn->context(), i, &name, &value);
63-
if(ret != 0)
62+
for(int i = 0; i < IIOContext::get_attrs_count(conn->context()); i++) {
63+
IIOResult<const iio_attr *> attrRes = IIOContext::get_attr(conn->context(), i);
64+
if(!attrRes.ok()) {
65+
qWarning(CAT_IIO_DEVICEIMPL) << "Cannot read the device info! (unavailable attribute)";
6466
continue;
67+
}
68+
69+
const iio_attr *attr = attrRes.data();
70+
const char *name = IIOAttribute::get_name(attr);
71+
const char *value = IIOAttribute::get_static_value(attr); // FIXME: This should work
6572
contextAttributes[name] = value;
6673
}
6774
ConnectionProvider::GetInstance()->close(m_param);

core/src/iiotabwidget.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,12 @@
2222
#include "iiotabwidget.h"
2323

2424
#include "iioutil/scopy-iioutil_config.h"
25+
#include <iioutil/iiocpp/iioscan.h>
26+
2527
#include "menusectionwidget.h"
2628
#include "qtconcurrentrun.h"
2729

28-
#include <iio.h>
30+
// #include <iio.h>
2931
#include <QLoggingCategory>
3032
#include <style.h>
3133
#include <stylehelper.h>
@@ -149,9 +151,9 @@ void IioTabWidget::setupConnections()
149151
QStringList IioTabWidget::computeBackendsList()
150152
{
151153
QStringList list;
152-
int backEndsCount = iio_get_backends_count();
153-
for(int i = 0; i < backEndsCount; i++) {
154-
QString backEnd(iio_get_backend(i));
154+
unsigned int backEndsCount = IIOScan::get_builtin_backends_count();
155+
for(unsigned i = 0; i < backEndsCount; i++) {
156+
QString backEnd(IIOScan::get_builtin_backend(i));
155157
if(backEnd.compare("xml") == 0 || backEnd.compare("serial") == 0) {
156158
continue;
157159
}
@@ -287,7 +289,7 @@ bool IioTabWidget::isSerialCompatible()
287289
#ifdef WITH_LIBSERIALPORT
288290
hasLibSerialPort = true;
289291
#endif
290-
bool hasSerialBackend = iio_has_backend("serial");
292+
bool hasSerialBackend = IIOScan::has_backend(nullptr, "serial");
291293
return hasLibSerialPort && hasSerialBackend;
292294
}
293295

gr-util/include/gr-util/griiodevicesource.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#include "grproxyblock.h"
2626
#include "scopy-gr-util_export.h"
2727

28-
#include <iio.h>
28+
#include <iio/iio.h>
2929

3030
#include <gnuradio/iio/device_source.h>
3131

@@ -40,7 +40,8 @@ class SCOPY_GR_UTIL_EXPORT GRIIOChannel : public GRProxyBlock
4040
: GRProxyBlock(parent)
4141
, channelName(channelName)
4242
, m_dev(dev)
43-
{}
43+
{
44+
}
4445
GRIIODeviceSource *getDeviceSrc() { return m_dev; }
4546
QString getChannelName() { return channelName; }
4647
virtual bool samplerateAttributeAvailable() { return false; }

gr-util/test/tst_grblocks.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "gr-util/grproxyblock.h"
2323
#include "gr-util/grsignalpath.h"
2424
#include "gr-util/grtopblock.h"
25+
#include <iioutil/iiocpp/iiocontext.h>
2526

2627
#include <gnuradio/blocks/head.h>
2728
#include <gnuradio/blocks/stream_to_vector.h>
@@ -661,7 +662,7 @@ void TST_GRBlocks::test5()
661662
top.registerSignalPath(ch2);
662663
ch3 = new GRSignalPath("complex", &top);
663664

664-
iio_context *ctx = iio_create_context_from_uri("ip:192.168.2.1");
665+
iio_context *ctx = scopy::IIOContext::create_context(nullptr, "ip:192.168.2.1");
665666
if(!ctx) {
666667
QSKIP("No context. Skipping");
667668
}

gui/src/deviceinfopage.cpp

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
*/
2121

2222
#include "deviceinfopage.h"
23+
#include <iioutil/iiocpp/iiocontext.h>
24+
#include <iioutil/iiocpp/iioattribute.h>
25+
#include <iioutil/iiocpp/iioresult.h>
2326
#include <QVBoxLayout>
2427
#include <QDebug>
2528

@@ -55,33 +58,36 @@ void DeviceInfoPage::setupInfoPage()
5558

5659
QString backendName, description;
5760
unsigned int major, minor;
58-
char git_tag[8] = "0000000";
59-
int ret = EXIT_FAILURE;
60-
ret = iio_context_get_version(m_conn->context(), &major, &minor, git_tag);
61-
if(ret) {
62-
qWarning() << "Error, cannot read backend version.";
63-
major = 'x';
64-
minor = 'x';
65-
}
61+
const char *versionTag;
62+
63+
major = IIOContext::get_version_major(m_conn->context());
64+
minor = IIOContext::get_version_minor(m_conn->context());
65+
versionTag = IIOContext::get_version_tag(m_conn->context());
6666

67-
backendName = iio_context_get_name(m_conn->context());
68-
description = iio_context_get_description(m_conn->context());
67+
backendName = IIOContext::get_name(m_conn->context());
68+
description = IIOContext::get_description(m_conn->context());
6969

7070
QString backendText = "IIO context created with %1 backend.\n"
7171
"Backend version: %2.%3 (git tag: %4)\n"
7272
"Backend description string: %5";
7373
m_backendInfo->setText(backendText.arg(backendName)
7474
.arg(QString::number(major))
7575
.arg(QString::number(minor))
76-
.arg(git_tag)
76+
.arg(versionTag)
7777
.arg(description));
7878

7979
const char *name;
8080
const char *value;
81-
for(int i = 0; i < iio_context_get_attrs_count(m_conn->context()); ++i) {
82-
int ret = iio_context_get_attr(m_conn->context(), i, &name, &value);
83-
if(ret != 0)
81+
for(int i = 0; i < IIOContext::get_attrs_count(m_conn->context()); ++i) {
82+
IIOResult<const iio_attr *> res = IIOContext::get_attr(m_conn->context(), i, &name, &value);
83+
if(!res.ok()) {
84+
qDebug() << "Error getting attribute at index" << i << "error code:" << res.error();
8485
continue;
86+
}
87+
88+
// TODO: check that get_static_value_works
89+
name = IIOAttribute::get_name(res.data());
90+
value = IIOAttribute::get_static_value(res.data());
8591

8692
m_infoPage->update(name, value);
8793
}

iio-widgets/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ endif()
7474
set(SCOPY_QT_COMPONENTS Core Widgets)
7575

7676
find_library(IIO_LIBRARIES NAMES iio libiio REQUIRED)
77-
find_path(IIO_INCLUDE_DIRS iio.h REQUIRED)
77+
find_path(IIO_INCLUDE_DIRS iio/iio.h REQUIRED)
7878

7979
set(PROJECT_SOURCES ${SRC_LIST} ${HEADER_LIST} ${UI_LIST})
8080

iio-widgets/include/iio-widgets/datastrategy/channelattrdatastrategy.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#define SCOPY_CHANNELATTRDATASTRATEGY_H
2323

2424
#include <QWidget>
25-
#include <iio.h>
2625
#include "datastrategy/datastrategyinterface.h"
2726
#include "iiowidgetdata.h"
2827
#include "scopy-iio-widgets_export.h"

iio-widgets/include/iio-widgets/datastrategy/contextattrdatastrategy.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#define SCOPY_CONTEXTATTRDATASTRATEGY_H
2424

2525
#include <QWidget>
26-
#include <iio.h>
2726
#include "datastrategyinterface.h"
2827
#include "scopy-iio-widgets_export.h"
2928

0 commit comments

Comments
 (0)