fix: use correct formula for acovercosf

anandkaranubc · anandkaranubc · commit 3920c117df8d · 2025-05-07T13:46:32.000-07:00
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/README.md b/lib/node_modules/@stdlib/math/base/special/acovercosf/README.md
@@ -26,10 +26,10 @@ limitations under the License.
 
 The [inverse coversed cosine][inverse-coversed-cosine] is defined as
 
-<!-- <equation class="equation" label="eq:arccovercosine" align="center" raw="\operatorname{acovercos}(\theta) = \arcsin(1+\theta)" alt="Inverse coversed cosine."> -->
+<!-- <equation class="equation" label="eq:arccovercosine" align="center" raw="\operatorname{acovercos}(\theta) = \arcsin(\theta-1)" alt="Inverse coversed cosine."> -->
 
 ```math
-\mathop{\mathrm{acovercos}}(\theta) = \arcsin(1+\theta)
+\mathop{\mathrm{acovercos}}(\theta) = \arcsin(\theta-1)
 ```
 
 <!-- </equation> -->
@@ -52,22 +52,22 @@ Computes the [inverse coversed cosine][inverse-coversed-cosine] of a single-prec
 
 ```javascript
 var v = acovercosf( 0.0 );
-// returns ~1.5708
+// returns ~-1.5708
 
-v = acovercosf( -3.141592653589793 / 2.0 );
-// returns ~-0.6075
+v = acovercosf( 3.141592653589793 / 2.0 );
+// returns ~0.6075
 
-v = acovercosf( -3.141592653589793 / 6.0 );
-// returns ~0.4966
+v = acovercosf( 3.141592653589793 / 6.0 );
+// returns ~-0.4966
 ```
 
-If `x < -2`, `x > 0`, or `x` is `NaN`, the function returns `NaN`.
+If `x < 0`, `x > 2`, or `x` is `NaN`, the function returns `NaN`.
 
 ```javascript
-var v = acovercosf( 1.0 );
+var v = acovercosf( -1.0 );
 // returns NaN
 
-v = acovercosf( -3.14 );
+v = acovercosf( 3.14 );
 // returns NaN
 
 v = acovercosf( NaN );
@@ -89,7 +89,7 @@ var uniform = require( '@stdlib/random/array/uniform' );
 var logEachMap = require( '@stdlib/console/log-each-map' );
 var acovercosf = require( '@stdlib/math/base/special/acovercosf' );
 
-var x = uniform( 100, -2.0, 0.0, {
+var x = uniform( 100, 0.0, 2.0, {
     'dtype': 'float32'
 });
 
@@ -131,8 +131,8 @@ logEachMap( 'acovercosf(%0.4f) = %0.4f', x, acovercosf );
 Computes the [inverse coversed cosine][inverse-coversed-cosine] of a single-precision floating-point number.
 
 ```c
-float out = stdlib_base_acovercosf( -3.141592653589793f / 2.0f );
-// returns ~-0.6075f
+float out = stdlib_base_acovercosf( 3.141592653589793f / 2.0f );
+// returns ~0.6075f
 ```
 
 The function accepts the following arguments:
@@ -166,7 +166,7 @@ float stdlib_base_acovercosf( const float x );
 #include <stdio.h>
 
 int main( void ) {
-    const float x[] = { -2.0f, -1.80f, -1.78f, -1.67f, -0.56f, -0.27f, -1.67f, -0.78f, -1.89f, 0.0f };
+    const float x[] = { 0.0f, 0.27f, 0.56f, 0.78f, 1.67f, 1.70f, 1.78f, 1.80f, 1.89f, 2.0f };
 
     float v;
     int i;
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.js
@@ -34,7 +34,7 @@ bench( pkg, function benchmark( b ) {
 	var y;
 	var i;
 
-	x = uniform( 100, -2.0, 0.0, {
+	x = uniform( 100, 0.0, 2.0, {
 		'dtype': 'float32'
 	});
 
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.native.js
@@ -43,7 +43,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	var y;
 	var i;
 
-	x = uniform( 100, -2.0, 0.0, {
+	x = uniform( 100, 0.0, 2.0, {
 		'dtype': 'float32'
 	});
 
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/c/native/benchmark.c
@@ -97,7 +97,7 @@ static double benchmark( void ) {
 	int i;
 
 	for ( i = 0; i < 100; i++ ) {
-		x[ i ] = -2.0f * rand_float();
+		x[ i ] = 2.0f * rand_float();
 	}
 
 	t = tic();
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/repl.txt b/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/repl.txt
@@ -3,9 +3,9 @@
     Computes the inverse coversed cosine of a single-precision floating-
     point number (in radians).
 
-    The inverse coversed cosine is defined as `asin(1+x)`.
+    The inverse coversed cosine is defined as `asin(x-1)`.
 
-    If `x < -2`, `x > 0`, or `x` is `NaN`, the function returns `NaN`.
+    If `x < 0`, `x > 2`, or `x` is `NaN`, the function returns `NaN`.
 
     Parameters
     ----------
@@ -19,10 +19,10 @@
 
     Examples
     --------
-    > var y = {{alias}}( -1.5 )
-    ~-0.5236
+    > var y = {{alias}}( 1.5 )
+    ~0.5236
     > y = {{alias}}( -0.0 )
-    ~1.5708
+    ~-1.5708
 
     See Also
     --------
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/types/index.d.ts b/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/types/index.d.ts
@@ -26,15 +26,15 @@
 *
 * @example
 * var v = acovercosf( 0.0 );
-* // returns ~1.5708
+* // returns ~-1.5708
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 2.0 );
-* // returns ~-0.6075
+* var v = acovercosf( 3.141592653589793 / 2.0 );
+* // returns ~0.6075
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 6.0 );
-* // returns ~0.4966
+* var v = acovercosf( 3.141592653589793 / 6.0 );
+* // returns ~-0.4966
 *
 * @example
 * var v = acovercosf( NaN );
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/types/test.ts b/lib/node_modules/@stdlib/math/base/special/acovercosf/docs/types/test.ts
@@ -23,7 +23,7 @@ import acovercosf = require( './index' );
 
 // The function returns a number...
 {
-	acovercosf( 8 ); // $ExpectType number
+	acovercosf( 1 ); // $ExpectType number
 }
 
 // The compiler throws an error if the function is provided a value other than a number...
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/acovercosf/examples/c/example.c
@@ -20,7 +20,7 @@
 #include <stdio.h>
 
 int main( void ) {
-	const float x[] = { -2.0f, -1.80f, -1.78f, -1.67f, -0.56f, -0.27f, -1.67f, -0.78f, -1.89f, 0.0f };
+	const float x[] = { 0.0f, 0.27f, 0.56f, 0.78f, 1.67f, 1.70f, 1.78f, 1.80f, 1.89f, 2.0f };
 
 	float v;
 	int i;
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/examples/index.js
@@ -22,7 +22,7 @@ var uniform = require( '@stdlib/random/array/uniform' );
 var logEachMap = require( '@stdlib/console/log-each-map' );
 var acovercosf = require( './../lib' );
 
-var x = uniform( 100, -2.0, 0.0, {
+var x = uniform( 100, 0.0, 2.0, {
 	'dtype': 'float32'
 });
 
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/index.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/index.js
@@ -27,13 +27,13 @@
 * var acovercosf = require( '@stdlib/math/base/special/acovercosf' );
 *
 * var v = acovercosf( 0.0 );
-* // returns ~1.5708
+* // returns ~-1.5708
 *
-* v = acovercosf( -3.141592653589793 / 2.0 );
-* // returns ~-0.6075
+* v = acovercosf( 3.141592653589793 / 2.0 );
+* // returns ~0.6075
 *
-* v = acovercosf( -3.141592653589793 / 6.0 );
-* // returns ~0.4966
+* v = acovercosf( 3.141592653589793 / 6.0 );
+* // returns ~-0.4966
 *
 * v = acovercosf( NaN );
 * // returns NaN
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/main.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/main.js
@@ -34,22 +34,22 @@ var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
 *
 * @example
 * var v = acovercosf( 0.0 );
-* // returns ~1.5708
+* // returns ~-1.5708
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 2.0 );
-* // returns ~-0.6075
+* var v = acovercosf( 3.141592653589793 / 2.0 );
+* // returns ~0.6075
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 6.0 );
-* // returns ~0.4966
+* var v = acovercosf( 3.141592653589793 / 6.0 );
+* // returns ~-0.4966
 *
 * @example
 * var v = acovercosf( NaN );
 * // returns NaN
 */
 function acovercosf( x ) {
-	return asinf( float64ToFloat32( 1.0 + float64ToFloat32( x ) ) );
+	return asinf( float64ToFloat32( float64ToFloat32( x ) - 1.0 ) );
 }
 
 
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/native.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/lib/native.js
@@ -34,15 +34,15 @@ var addon = require( './../src/addon.node' );
 *
 * @example
 * var v = acovercosf( 0.0 );
-* // returns ~1.5708
+* // returns ~-1.5708
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 2.0 );
-* // returns ~-0.6075
+* var v = acovercosf( 3.141592653589793 / 2.0 );
+* // returns ~0.6075
 *
 * @example
-* var v = acovercosf( -3.141592653589793 / 6.0 );
-* // returns ~0.4966
+* var v = acovercosf( 3.141592653589793 / 6.0 );
+* // returns ~-0.4966
 *
 * @example
 * var v = acovercosf( NaN );
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/src/main.c b/lib/node_modules/@stdlib/math/base/special/acovercosf/src/main.c
@@ -27,8 +27,8 @@
 *
 * @example
 * float out = stdlib_base_acovercosf( 0.0f );
-* // returns ~1.5708f
+* // returns ~-1.5708f
 */
 float stdlib_base_acovercosf( const float x ) {
-	return stdlib_base_asinf( 1.0f + x );
+	return stdlib_base_asinf( x - 1.0f );
 }
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/data.json b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/data.json
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/runner.jl b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/runner.jl
@@ -19,7 +19,7 @@
 import JSON
 
 """
-    gen( domain, name )
+	gen( domain, name )
 
 Generate fixture data and write to file.
 
@@ -37,7 +37,7 @@ julia> gen( x, \"data.json\" );
 """
 function gen( domain, name )
 	x = collect( domain );
-	y = asin.( 1.0 .+ x );
+	y = asin.( x .- 1.0 );
 
 	# Store data to be written to file as a collection:
 	data = Dict([
@@ -62,9 +62,9 @@ file = @__FILE__;
 dir = dirname( file );
 
 # Generate fixture data for decimal values:
-x = range( -2.0, stop = 0.0, length = 2003 );
+x = range( 0.0, stop = 2.0, length = 2003 );
 gen( x, "data.json" );
 
-# Generate fixture data for small negative values:
-x = range( -1e-20, stop = -1e-28, length = 2003 );
-gen( x, "small_negative.json" );
+# Generate fixture data for small positive values:
+x = range( 1e-208, stop = 1e-200, length = 2003 );
+gen( x, "small_positive.json" );
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/small_negative.json b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/small_negative.json
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/small_positive.json b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/fixtures/julia/small_positive.json
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js
@@ -32,7 +32,7 @@ var acovercosf = require( './../lib' );
 // FIXTURES //
 
 var data = require( './fixtures/julia/data.json' );
-var smallNegative = require( './fixtures/julia/small_negative.json' );
+var smallPositive = require( './fixtures/julia/small_positive.json' );
 
 
 // TESTS //
@@ -69,7 +69,7 @@ tape( 'the function computes the inverse coversed cosine', function test( t ) {
 	t.end();
 });
 
-tape( 'the function computes the inverse coversed cosine (small negative numbers)', function test( t ) {
+tape( 'the function computes the inverse coversed cosine (small positive numbers)', function test( t ) {
 	var expected;
 	var delta;
 	var tol;
@@ -78,8 +78,8 @@ tape( 'the function computes the inverse coversed cosine (small negative numbers
 	var i;
 	var e;
 
-	x = smallNegative.x;
-	expected = smallNegative.expected;
+	x = smallPositive.x;
+	expected = smallPositive.expected;
 
 	for ( i = 0; i < x.length; i++ ) {
 		e = float64ToFloat32( expected[ i ] );
@@ -101,21 +101,21 @@ tape( 'the function returns `NaN` if provided a `NaN`', function test( t ) {
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided a value less than `-2`', function test( t ) {
+tape( 'the function returns `NaN` if provided a value less than `0`', function test( t ) {
 	var v;
 	var i;
 	for ( i = 0; i < 1e4; i++ ) {
-		v = -( randu() * 1.0e6 ) - ( 2.0 + EPS );
+		v = -( randu() * 1.0e6 ) - EPS;
 		t.strictEqual( isnanf( acovercosf( v ) ), true, 'returns expected value when provided '+v );
 	}
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided a value greater than `0`', function test( t ) {
+tape( 'the function returns `NaN` if provided a value greater than `2`', function test( t ) {
 	var v;
 	var i;
 	for ( i = 0; i < 1e4; i++ ) {
-		v = ( randu() * 1.0e6 ) + 0.0 + EPS;
+		v = ( randu() * 1.0e6 ) + ( 2.0+EPS );
 		t.strictEqual( isnanf( acovercosf( v ) ), true, 'returns expected value when provided '+v );
 	}
 	t.end();
diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js
@@ -33,7 +33,7 @@ var tryRequire = require( '@stdlib/utils/try-require' );
 // FIXTURES //
 
 var data = require( './fixtures/julia/data.json' );
-var smallNegative = require( './fixtures/julia/small_negative.json' );
+var smallPositive = require( './fixtures/julia/small_positive.json' );
 
 
 // VARIABLES //
@@ -78,7 +78,7 @@ tape( 'the function computes the inverse coversed cosine', opts, function test(
 	t.end();
 });
 
-tape( 'the function computes the inverse coversed cosine (small negative numbers)', opts, function test( t ) {
+tape( 'the function computes the inverse coversed cosine (small positive numbers)', opts, function test( t ) {
 	var expected;
 	var delta;
 	var tol;
@@ -87,8 +87,8 @@ tape( 'the function computes the inverse coversed cosine (small negative numbers
 	var i;
 	var e;
 
-	x = smallNegative.x;
-	expected = smallNegative.expected;
+	x = smallPositive.x;
+	expected = smallPositive.expected;
 
 	for ( i = 0; i < x.length; i++ ) {
 		e = float64ToFloat32( expected[ i ] );
@@ -110,21 +110,21 @@ tape( 'the function returns `NaN` if provided a `NaN`', opts, function test( t )
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided a value less than `-2`', opts, function test( t ) {
+tape( 'the function returns `NaN` if provided a value less than `0`', opts, function test( t ) {
 	var v;
 	var i;
 	for ( i = 0; i < 1e4; i++ ) {
-		v = -( randu() * 1.0e6 ) - ( 2.0 + EPS );
+		v = -( randu() * 1.0e6 ) - EPS;
 		t.strictEqual( isnanf( acovercosf( v ) ), true, 'returns expected value when provided '+v );
 	}
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided a value greater than `0`', opts, function test( t ) {
+tape( 'the function returns `NaN` if provided a value greater than `2`', opts, function test( t ) {
 	var v;
 	var i;
 	for ( i = 0; i < 1e4; i++ ) {
-		v = ( randu() * 1.0e6 ) + 0.0 + EPS;
+		v = ( randu() * 1.0e6 ) + ( 2.0+EPS );
 		t.strictEqual( isnanf( acovercosf( v ) ), true, 'returns expected value when provided '+v );
 	}
 	t.end();

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ static double benchmark( void ) {`
`97`	`97`	`int i;`
`98`	`98`
`99`	`99`	`for ( i = 0; i < 100; i++ ) {`
`100`		`- x[ i ] = -2.0f * rand_float();`
	`100`	`+ x[ i ] = 2.0f * rand_float();`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`t = tic();`
Original file line number	Diff line number	Diff line change
`@@ -26,15 +26,15 @@`
`26`	`26`	`*`
`27`	`27`	`* @example`
`28`	`28`	`* var v = acovercosf( 0.0 );`
`29`		`-* // returns ~1.5708`
	`29`	`+* // returns ~-1.5708`
`30`	`30`	`*`
`31`	`31`	`* @example`
`32`		`-* var v = acovercosf( -3.141592653589793 / 2.0 );`
`33`		`-* // returns ~-0.6075`
	`32`	`+* var v = acovercosf( 3.141592653589793 / 2.0 );`
	`33`	`+* // returns ~0.6075`
`34`	`34`	`*`
`35`	`35`	`* @example`
`36`		`-* var v = acovercosf( -3.141592653589793 / 6.0 );`
`37`		`-* // returns ~0.4966`
	`36`	`+* var v = acovercosf( 3.141592653589793 / 6.0 );`
	`37`	`+* // returns ~-0.4966`
`38`	`38`	`*`
`39`	`39`	`* @example`
`40`	`40`	`* var v = acovercosf( NaN );`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ import acovercosf = require( './index' );`
`23`	`23`
`24`	`24`	`// The function returns a number...`
`25`	`25`	`{`
`26`		`- acovercosf( 8 ); // $ExpectType number`
	`26`	`+ acovercosf( 1 ); // $ExpectType number`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`// The compiler throws an error if the function is provided a value other than a number...`
Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,13 @@`
`27`	`27`	`* var acovercosf = require( '@stdlib/math/base/special/acovercosf' );`
`28`	`28`	`*`
`29`	`29`	`* var v = acovercosf( 0.0 );`
`30`		`-* // returns ~1.5708`
	`30`	`+* // returns ~-1.5708`
`31`	`31`	`*`
`32`		`-* v = acovercosf( -3.141592653589793 / 2.0 );`
`33`		`-* // returns ~-0.6075`
	`32`	`+* v = acovercosf( 3.141592653589793 / 2.0 );`
	`33`	`+* // returns ~0.6075`
`34`	`34`	`*`
`35`		`-* v = acovercosf( -3.141592653589793 / 6.0 );`
`36`		`-* // returns ~0.4966`
	`35`	`+* v = acovercosf( 3.141592653589793 / 6.0 );`
	`36`	`+* // returns ~-0.4966`
`37`	`37`	`*`
`38`	`38`	`* v = acovercosf( NaN );`
`39`	`39`	`* // returns NaN`