Added integration tests and updated FAQ

Author: Ander Corral

.github/workflows/push.yml

@@ -192,6 +192,13 @@ jobs:
           -report_every 5 -train_steps 10 \
           -save_model /tmp/onmt.model \
           -save_checkpoint_steps 10
+    - name: Testing translation with features
+      run: |
+        python translate.py \
+            -model /tmp/onmt.model_step_10.pt \
+            -src data/data_features/src-test.txt \
+            -src_feats "{'feat0': 'data/data_features/src-test.feat0'}" \
+            -verbose
     - name: Test RNN translation
       run: |
         head data/src-test.txt > /tmp/src-test.txt

docs/source/FAQ.md

@@ -527,4 +527,12 @@ src_feats_vocab:
     feat_1: exp/data.vocab.feat_1
 feat_merge: "sum"
 
-```
+```
+
+During inference you can pass features by using the `--src_feats` argument. 
+
+**Important note!** During inference, input sentence is expected to be tokenized. Therefore feature inferring should be handled prior to running the translate command. Example:
+
+```bash
+python translate.py -model model_step_10.pt -src ../data.txt.tok -output ../data.out --src_feats "{'feat_0': '../data.txt.feats0', 'feat_1': '../data.txt.feats1'}"
+```

onmt/tests/pull_request_chk.sh

@@ -276,7 +276,7 @@ ${PYTHON} onmt/bin/train.py \
             -rnn_size 2 -batch_size 10 \
             -word_vec_size 5 -rnn_size 10 \
             -report_every 5 -train_steps 10 \
-            -save_model $TMP_OUT_DIR/onmt.model \
+            -save_model $TMP_OUT_DIR/onmt.features.model \
             -save_checkpoint_steps 10 >> ${LOG_FILE} 2>&1
 [ "$?" -eq 0 ] || error_exit
 echo "Succeeded" | tee -a ${LOG_FILE}
@@ -297,6 +297,16 @@ ${PYTHON} translate.py -model ${TEST_DIR}/test_model.pt -src $TMP_OUT_DIR/src-te
 echo "Succeeded" | tee -a ${LOG_FILE}
 rm $TMP_OUT_DIR/src-test.txt
 
+echo -n "  [+] Testing NMT translation with features..."
+${PYTHON} translate.py \
+            -model ${TMP_OUT_DIR}/onmt.features.model_step_10.pt \
+            -src ${DATA_DIR}/data_features/src-test.txt \
+            -src_feats "{'feat0': '${DATA_DIR}/data_features/src-test.feat0'}" \
+            -verbose >> ${LOG_FILE} 2>&1
+[ "$?" -eq 0 ] || error_exit
+echo "Succeeded" | tee -a ${LOG_FILE}
+rm -f $TMP_OUT_DIR/onmt.features.model*
+
 echo -n "  [+] Testing NMT ensemble translation..."
 head ${DATA_DIR}/src-test.txt > $TMP_OUT_DIR/src-test.txt
 ${PYTHON} translate.py -model ${TEST_DIR}/test_model.pt ${TEST_DIR}/test_model.pt \