Skip to content

Commit 5802bbf

Browse files
ganpa3timabbott
authored andcommitted
ui_report: Add ui_report.client_error.
1 parent e243af5 commit 5802bbf

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

static/js/ui_report.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ exports.error = function (response, xhr, status_box, remove_after) {
4343
exports.message(response, status_box, "alert-error", remove_after);
4444
};
4545

46+
exports.client_error = function (response, status_box, remove_after) {
47+
exports.message(response, status_box, "alert-error", remove_after);
48+
};
49+
4650
exports.success = function (response, status_box, remove_after) {
4751
exports.message(response, status_box, "alert-success", remove_after);
4852
};

tools/linter_lib/custom_check.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
{'pattern': r'ui.report_success\(',
140140
'description': 'Deprecated function, use ui_report.success.'},
141141
{'pattern': r'''report.success\(["']''',
142-
'description': 'Argument to report_success should be a literal string enclosed '
142+
'description': 'Argument to ui_report.success should be a literal string enclosed '
143143
'by i18n.t()'},
144144
{'pattern': r'ui.report_error\(',
145145
'description': 'Deprecated function, use ui_report.error.'},
@@ -148,6 +148,11 @@
148148
'by i18n.t()',
149149
'good_lines': ['ui_report.error("")', 'ui_report.error(_("text"))'],
150150
'bad_lines': ['ui_report.error("test")']},
151+
{'pattern': r'''report.client_error\(["'][^'"]''',
152+
'description': 'Argument to ui_report.client_error should be a literal string enclosed '
153+
'by i18n.t()',
154+
'good_lines': ['ui_report.client_error("")', 'ui_report.client_error(_("text"))'],
155+
'bad_lines': ['ui_report.client_error("test")']},
151156
{'pattern': r'\$\(document\)\.ready\(',
152157
'description': "`Use $(f) rather than `$(document).ready(f)`",
153158
'good_lines': ['$(function () {foo();}'],

0 commit comments

Comments
 (0)