fix cpplint issues (onnx#7650)

### Motivation and Context

Fixes #

---------

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>

Author: andife

.github/workflows/manylinux/entrypoint.sh

@@ -68,7 +68,7 @@ fi
 # find -exec does not preserve failed exit codes, so use an output file for failures
 failed_wheels=$PWD/failed-wheels
 rm -f "$failed_wheels"
-find . -type f -iname "*-linux*.whl" -exec sh -c "auditwheel repair '{}' -w \$(dirname '{}') --plat '${PLAT}' || { echo 'Repairing wheels failed.'; auditwheel show '{}' >> '$failed_wheels'; }" \;
+find . -type f -iname "*-linux*.whl" -exec sh -c 'auditwheel repair "$1" -w "$(dirname "$1")" --plat "$2" || { echo "Repairing wheels failed."; auditwheel show "$1" >> "$3"; }' _ {} "${PLAT}" "$failed_wheels" \;
 
 if [[ -f "$failed_wheels" ]]; then
     echo "Repairing wheels failed:"

docs/IR.md

@@ -381,7 +381,7 @@ The dynamic-optional allows for more expressiveness than static-optional.
 
 #### External Tensor Data
 
-The raw data for large constant tensors, such as initializers, MAY be serialised in a separate file. In such a case, the tensor MUST provide the filename relative to the model file and MUST NOT use the value fields. It MAY provide a byte offset and length within that file. It MAY also specify a SHA1 digest of the file. One file MAY contain the data for multiple tensors.
+The raw data for large constant tensors, such as initializers, MAY be serialized in a separate file. In such a case, the tensor MUST provide the filename relative to the model file and MUST NOT use the value fields. It MAY provide a byte offset and length within that file. It MAY also specify a SHA1 digest of the file. One file MAY contain the data for multiple tensors.
 
 More details can be found in [External Data](ExternalData.md).
 

onnx/checker.cc

@@ -4,7 +4,7 @@
 
 #include "onnx/checker.h"
 
-#include <filesystem>
+#include <filesystem> // NOLINT(build/c++17)
 #include <iostream>
 #include <string>
 #include <unordered_map>

onnx/common/array_ref.h

@@ -61,7 +61,7 @@ class ArrayRef {
   /*implicit*/ ArrayRef() : Data(nullptr), Length(0) {}
 
   /// Construct an ArrayRef from a single element.
-  /// NOLINTNEXTLINE(google-explicit-constructor)
+  // NOLINTNEXTLINE(google-explicit-constructor, runtime/explicit)
   /*implicit*/ ArrayRef(const T& OneElt) : Data(&OneElt), Length(1) {}
 
   /// Construct an ArrayRef from a pointer and length.
@@ -72,17 +72,17 @@ class ArrayRef {
 
   /// Construct an ArrayRef from a std::vector.
   template <typename A>
-  /// NOLINTNEXTLINE(google-explicit-constructor)
+  // NOLINTNEXTLINE(google-explicit-constructor, runtime/explicit)
   /*implicit*/ ArrayRef(const std::vector<T, A>& Vec) : Data(Vec.data()), Length(Vec.size()) {}
 
   /// Construct an ArrayRef from a std::array
   template <size_t N>
-  /// NOLINTNEXTLINE(google-explicit-constructor)
+  // NOLINTNEXTLINE(google-explicit-constructor, runtime/explicit)
   /*implicit*/ constexpr ArrayRef(const std::array<T, N>& Arr) : Data(Arr.data()), Length(N) {}
 
   /// Construct an ArrayRef from a C array.
   template <size_t N>
-  /// NOLINTNEXTLINE(google-explicit-constructor, *array*)
+  // NOLINTNEXTLINE(google-explicit-constructor, runtime/explicit)
   /*implicit*/ constexpr ArrayRef(const T (&Arr)[N]) : Data(Arr), Length(N) {}
 
   /// Construct an ArrayRef from a std::initializer_list.

onnx/common/common.h

@@ -13,10 +13,10 @@
     abort();                                              \
   } while (false)
 
-#define ONNX_THROW_EX(ex)                \
-  do {                                   \
-    std::cerr << ex.what() << std::endl; \
-    abort();                             \
+#define ONNX_THROW_EX(ex)                             \
+  do {                                                \
+    std::cerr << ex.what() << std::endl; /* NOLINT */ \
+    abort();                                          \
   } while (false)
 
 #define ONNX_TRY if (true)

onnx/common/file_utils.h

@@ -4,7 +4,7 @@
 
 #pragma once
 
-#include <filesystem>
+#include <filesystem> // NOLINT(build/c++17)
 #include <fstream>
 #include <string>
 

onnx/common/interned_strings.h

@@ -197,7 +197,7 @@ enum BuiltinSymbol : std::uint8_t {
 
 struct Symbol {
   Symbol() = default;
-  // NOLINTNEXTLINE(google-explicit-constructor)
+  // NOLINTNEXTLINE(google-explicit-constructor, runtime/explicit)
   /*implicit*/ Symbol(BuiltinSymbol value) : value(value) {}
   explicit Symbol(const std::string& s);
   explicit Symbol(uint32_t value) : value(value) {}

onnx/common/ir.h

@@ -1276,9 +1276,9 @@ struct Graph final {
   }
 };
 
-inline Value::Value(Node* node_, size_t offset_)
-    : node_(node_), offset_(offset_), unique_(node_->graph_->getNextUnique()), stage_(node_->graph_->new_node_stage_) {
-  node_->graph_->all_values.emplace(this);
+inline Value::Value(Node* node, size_t offset)
+    : node_(node), offset_(offset), unique_(node->graph_->getNextUnique()), stage_(node->graph_->new_node_stage_) {
+  node->graph_->all_values.emplace(this);
 }
 
 inline Graph* Value::owningGraph() {

onnx/defs/rnn/old.cc

@@ -394,7 +394,7 @@ static std::function<void(OpSchema&)> RNNDocGeneratorOld(const char* /*name*/) {
         "Specify if the RNN is forward, reverse, or bidirectional. "
         "Must be one of forward (default), reverse, or bidirectional.",
         AttributeProto::STRING,
-        std::string("foward"));
+        std::string("foward")); // reviewdog:ignore[misspell], don't fix that typo, it's fixed in newer versions
     schema.Attr("hidden_size", "Number of neurons in the hidden layer", AttributeProto::INT, OPTIONAL_VALUE);
     schema.Attr(
         "activation_alpha",