Passing an URL to `add` when a "forge" input type is used fails

[samueldr]

This is a UX issue.

---

I mindlessly used the following command:

 $ npins add gitlab https://source.denx.de/u-boot/u-boot

When it should have been:

 $ npins add gitlab --server https://source.denx.de/ u-boot/u-boot

At least for forges, and other relevant input types where an URL is not the expected format used for an input, something could be done...

• If possible and sensible, guessing --server
• Eagerly fail on input that's incorrect

Though to be fair, I don't know if somehow for some awful reason GitLab (or other input types) could have supported https:// somewhere in org names or other organizational structure... If that's the case, there's not much that could be done. Though I'm pretty sure that at least GitLab is pretty strict here.

[piegamesde]

I think it should be possible to make the CLI smart and either do the right thing or at least recognize the error and tell you touse npins add git https://source.denx.de/u-boot/u-boot instead

[samueldr]

To be more correct, in this case this is a GitLab instance, so it shouldn't use git (the input type was correct).

But otherwise yes, especially if each input type is handling deciding whether an URL is "valid" or not, and what to do with those.

[piegamesde]

(FWIW if you don't trust the auto-detection of forges you can specify npins add git --forge=gitlab https://source.denx.de/u-boot/u-boot which should be fully equivalent to npins add gitlab --server https://source.denx.de/ u-boot/u-boot)

[samueldr]

Oh, I see what you meant: I didn't know there was auto-detection of forge.

[piegamesde]

it's brand new from the last release ^^