pr feedback

Author: andiwand

Core/include/Acts/Seeding2/CylindricalSpacePointGrid2.hpp

@@ -30,12 +30,14 @@ class CylindricalSpacePointGrid2 {
   /// Space point index type used in the grid.
   using SpacePointIndex = std::uint32_t;
   using BinType = std::vector<SpacePointIndex>;
-  /// Cylindrical space point bin is a 2D (phi,z) grid. It stores a vector of
-  /// space point indices.
-  using GridType =
-      Grid<BinType, Axis<AxisType::Equidistant, AxisBoundaryType::Closed>,
-           Axis<AxisType::Variable, AxisBoundaryType::Open>,
-           Axis<AxisType::Variable, AxisBoundaryType::Open>>;
+  using PhiAxisType = Axis<AxisType::Equidistant, AxisBoundaryType::Closed>;
+  using ZAxisType = Axis<AxisType::Variable, AxisBoundaryType::Open>;
+  using RAxisType = Axis<AxisType::Variable, AxisBoundaryType::Open>;
+  /// Cylindrical space point grid type, which is a grid over `BinType` with
+  /// axes defined by `PhiAxisType`, `ZAxisType`, and `RAxisType`.
+  /// The grid is a 3D grid with the axes representing azimuthal angle (phi),
+  /// z-coordinate, and radial distance (r).
+  using GridType = Grid<BinType, PhiAxisType, ZAxisType, RAxisType>;
   using BinnedGroupType = BinnedGroup<GridType>;
 
   struct Config {

Core/src/Seeding2/CylindricalSpacePointGrid2.cpp

@@ -105,7 +105,7 @@ CylindricalSpacePointGrid2::CylindricalSpacePointGrid2(
     phiBins = std::min(phiBins, m_cfg.maxPhiBins);
   }
 
-  Axis phiAxis(AxisClosed, m_cfg.phiMin, m_cfg.phiMax, phiBins);
+  PhiAxisType phiAxis(AxisClosed, m_cfg.phiMin, m_cfg.phiMax, phiBins);
 
   // vector that will store the edges of the bins of z
   std::vector<double> zValues{};
@@ -142,8 +142,8 @@ CylindricalSpacePointGrid2::CylindricalSpacePointGrid2(
                    m_cfg.rBinEdges.end());
   }
 
-  Axis zAxis(AxisOpen, std::move(zValues));
-  Axis rAxis(AxisOpen, std::move(rValues));
+  ZAxisType zAxis(AxisOpen, std::move(zValues));
+  RAxisType rAxis(AxisOpen, std::move(rValues));
 
   ACTS_VERBOSE("Defining Grid:");
   ACTS_VERBOSE("- Phi Axis: " << phiAxis);