Skip to content

Commit 7ac4529

Browse files
committed
Fix CI for Microsoft Visual Studio 2019 (#45)
The CI was using the image "windows-latest" to test with MSVC 2019. However, windows-latest changed to MSVC 2022, so the CI failed. This patch changes these configurations from windows-latest to windows-2019.
1 parent c0ba960 commit 7ac4529

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/cmake.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,14 @@ jobs:
9595
}
9696
- {
9797
name: "Windows MSVC 2019 (x64) C++17",
98-
os: windows-latest,
98+
os: windows-2019,
9999
cxx: "cl",
100100
environment_script: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
101101
cxxver: 17,
102102
}
103103
- {
104104
name: "Windows MSVC 2019 (x64) C++20",
105-
os: windows-latest,
105+
os: windows-2019,
106106
cxx: "cl",
107107
environment_script: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
108108
cxxver: 20,

include/cppcoro/async_scope.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ namespace cppcoro
8686
struct promise_type
8787
{
8888
cppcoro::suspend_never initial_suspend() { return {}; }
89-
cppcoro::suspend_never final_suspend() { return {}; }
89+
cppcoro::suspend_never final_suspend() noexcept { return {}; }
9090
void unhandled_exception() { std::terminate(); }
9191
oneway_task get_return_object() { return {}; }
9292
void return_void() {}

0 commit comments

Comments
 (0)